···
On Monday, August 4, 2014 10:23:12 AM UTC+3, boaz s wrote:
>
> Hi all,
>
> In addition to my previous post
> , I have
> noticed that there is a broken link in Foreman Manual at the Puppet Report
> chapter.
> When we're asked to copy foreman-report_v2.rb.erb from here
> ,
> I get "Not Found" message.
> Digging into it, I have discovered that foreman-report_v2.rb.erb is no
> longer used at the foreman-puppet's master branch.
> Moreover, the foreman-report_v2.rb.erb at 2.1_stable branch
>
> is pretty identical to my
> /usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
>
> $ diff /usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
> foreman-report_v2.rb.erb
> 6c6
> < $foreman_url='https://foreman-ops.scl.lab.tlv.redhat.com'
> ---
> > $foreman_url='<%= @foreman_url %>'
> 8c8
> < $foreman_ssl_ca = "/var/lib/puppet/ssl/certs/ca.pem"
> ---
> > $foreman_ssl_ca = "<%= @ssl_ca -%>"
> 10,11c10,11
> < $foreman_ssl_cert =
> "/var/lib/puppet/ssl/certs/foreman-ops.scl.lab.tlv.redhat.com.pem"
> < $foreman_ssl_key =
> "/var/lib/puppet/ssl/private_keys/foreman-ops.scl.lab.tlv.redhat.com.pem"
> ---
> > $foreman_ssl_cert = "<%= @ssl_cert -%>"
> > $foreman_ssl_key = "<%= @ssl_key -%>"
>
> I can push a PR with the following changes
>
> :
>
> 1. Modify the foreman-report_v2.rb.erb url to the one at 2.1_stable
> branch
>
> 2. Add a note saying that this step is not required for Foreman 1.5.2+
>
> Best Regards.
>
> 2. Add a note saying that this step is not required for Foreman 1.5.2+
I don't think this is needed - it's used on Foreman 1.5 still, it's just
that yours has probably been set up by the installer. We'll write up
new instructions for Foreman 1.6 due to the change.
I have found two other places with a similar problem.
I have PR`ed a fix here:
I'm pretty sure these are the last ones (grep has confirmed that).
BR.
···
On Monday, August 4, 2014 10:23:12 AM UTC+3, boaz s wrote:
>
> Hi all,
>
> In addition to my previous post
> , I have
> noticed that there is a broken link in Foreman Manual at the Puppet Report
> chapter.
> When we're asked to copy foreman-report_v2.rb.erb from here
> ,
> I get "Not Found" message.
> Digging into it, I have discovered that foreman-report_v2.rb.erb is no
> longer used at the foreman-puppet's master branch.
> Moreover, the foreman-report_v2.rb.erb at 2.1_stable branch
>
> is pretty identical to my
> /usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
>
> $ diff /usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
> foreman-report_v2.rb.erb
> 6c6
> < $foreman_url='https://foreman-ops.scl.lab.tlv.redhat.com'
> ---
> > $foreman_url='<%= @foreman_url %>'
> 8c8
> < $foreman_ssl_ca = "/var/lib/puppet/ssl/certs/ca.pem"
> ---
> > $foreman_ssl_ca = "<%= @ssl_ca -%>"
> 10,11c10,11
> < $foreman_ssl_cert =
> "/var/lib/puppet/ssl/certs/foreman-ops.scl.lab.tlv.redhat.com.pem"
> < $foreman_ssl_key =
> "/var/lib/puppet/ssl/private_keys/foreman-ops.scl.lab.tlv.redhat.com.pem"
> ---
> > $foreman_ssl_cert = "<%= @ssl_cert -%>"
> > $foreman_ssl_key = "<%= @ssl_key -%>"
>
> I can push a PR with the following changes
>
> :
>
> 1. Modify the foreman-report_v2.rb.erb url to the one at 2.1_stable
> branch
>
> 2. Add a note saying that this step is not required for Foreman 1.5.2+
>
> Best Regards.
>
On Monday, August 4, 2014 10:23:12 AM UTC+3, boaz s wrote:
Hi all,
In addition to my previous post
<https://groups.google.com/forum/#!topic/foreman-dev/y0D16sobjoM>, I
have noticed that there is a broken link in Foreman Manual at the
Puppet Report
<http://theforeman.org/manuals/1.5/index.html#3.5.4PuppetReports>
chapter.
When we're asked to copy foreman-report_v2.rb.erb from here
<https://raw.github.com/theforeman/puppet-foreman/master/templates/foreman-report_v2.rb.erb>,
I get "Not Found" message.
Digging into it, I have discovered that foreman-report_v2.rb.erb is
no longer used at the foreman-puppet's master branch.
Moreover, the foreman-report_v2.rb.erb at 2.1_stable branch
<https://github.com/theforeman/puppet-foreman/blob/2.1-stable/templates/foreman-report_v2.rb.erb>
is pretty identical to my
/usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
$ diff /usr/lib/ruby/site_ruby/1.8/puppet/reports/foreman.rb
foreman-report_v2.rb.erb
6c6
< $foreman_url='https://foreman-ops.scl.lab.tlv.redhat.com
<https://foreman-ops.scl.lab.tlv.redhat.com>'
---
> $foreman_url='<%= @foreman_url %>'
8c8
< $foreman_ssl_ca = "/var/lib/puppet/ssl/certs/ca.pem"
---
> $foreman_ssl_ca = "<%= @ssl_ca -%>"
10,11c10,11
< $foreman_ssl_cert =
"/var/lib/puppet/ssl/certs/foreman-ops.scl.lab.tlv.redhat.com.pem"
< $foreman_ssl_key =
"/var/lib/puppet/ssl/private_keys/foreman-ops.scl.lab.tlv.redhat.com.pem"
---
> $foreman_ssl_cert = "<%= @ssl_cert -%>"
> $foreman_ssl_key = "<%= @ssl_key -%>"
I can push a PR with the following changes
<https://github.com/theforeman/theforeman.org/blob/gh-pages/_includes/manuals/1.5/3.5.4_puppet_reports.md>:
1. Modify the foreman-report_v2.rb.erb url to the one at 2.1_stable
branch
<https://github.com/theforeman/puppet-foreman/blob/2.1-stable/templates/foreman-report_v2.rb.erb>
2. Add a note saying that this step is not required for Foreman 1.5.2+
Best Regards.
