I'm curious what everyone's thoughts/feedback are on this feature and would
really appreciate it if someone else would install it and try it out. I'm
not a Rails coder by profession so hopefully it doesn't look to ugly to
experienced eyes.
> I'm curious what everyone's thoughts/feedback are on this feature and
> would really appreciate it if someone else would install it and try it out.
> I'm not a Rails coder by profession so hopefully it doesn't look to ugly to
> experienced eyes.
>
> The commit is here:
>
> https://github.com/rbirnie/foreman/commit/e4b4b4fa0d8a934ac578821e9c2a1fc1a96474c7
>
> And Issue I opened to track it is here:
> Feature #1906: Add Trends Page to track changes in Fact host counts - Foreman
>
> I've never submitted stuff before, so I didn't want to create the pull
> request till I got some feedback from everyone.
>
> This looks pretty good on a very quick glance (i didnt try it out yet etc).
would you consider moving the trending into after_save callbacks in models
(or maybe better in observers)?
thanks!!
Ohad
···
On Thu, Oct 18, 2012 at 9:03 PM, Robert wrote:
On Thu, Oct 18, 2012 at 9:03 PM, Robert rbirnie@gmail.com wrote:
I’m curious what everyone’s thoughts/feedback are on this feature and would really appreciate it if someone else would install it and try it out. I’m not a Rails coder by profession so hopefully it doesn’t look to ugly to experienced eyes.
