Underscores vs hyphens in hammer

Development
#1

I noticed in Katello's commands, there are hyphens (e.g. hammer lifecycle-environment create) but in the Foreman commands, there are underscores (e.g. hammer partition_table create). I'm wondering if we should probably use the same format? And if so, which of the two?

David

#2

Foreman was first, it wins :slight_smile:

– bk

··· On 02/04/2014 11:08 AM, David Davis wrote: > I noticed in Katello's commands, there are hyphens (e.g. hammer lifecycle-environment create) but in the Foreman commands, there are underscores (e.g. hammer partition_table create). I'm wondering if we should probably use the same format? And if so, which of the two? > > David >
#3

Also "-" is more consistent with other command-line commands than "_".

··· On Tuesday, February 4, 2014 2:08:27 PM UTC-2, David Davis wrote: > > I noticed in Katello's commands, there are hyphens (e.g. hammer > lifecycle-environment create) but in the Foreman commands, there are > underscores (e.g. hammer partition_table create). I'm wondering if we > should probably use the same format? And if so, which of the two? > > David >
#4

It's a bit inconsistent to use _ when all the command options get auto-generated into -.

Consistency wins over first arrival!

··· ----- Original Message ----- > From: "Bryan Kearney" > To: foreman-dev@googlegroups.com > Sent: Tuesday, February 4, 2014 11:08:59 AM > Subject: Re: [foreman-dev] Underscores vs hyphens in hammer > > On 02/04/2014 11:08 AM, David Davis wrote: > > I noticed in Katello's commands, there are hyphens (e.g. hammer > > lifecycle-environment create) but in the Foreman commands, there are > > underscores (e.g. hammer partition_table create). I'm wondering if we > > should probably use the same format? And if so, which of the two? > > > > David > > > Foreman was first, it wins :) > > -- bk > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
#5

Since I have already automated many areas in the Foreman CLI I will vote to
keep it like Foreman does

#6

+1

examples:

git-*
virt-*
system-config-*
etc …

$ ls /usr/bin/ |grep "_" | wc -l
173

$ ls /usr/bin/ |grep "-" | wc -l
805

··· On 02/05/2014 06:43 AM, Elyézer Rezende wrote: > Also "-" is more consistent with other command-line commands than "_". > > On Tuesday, February 4, 2014 2:08:27 PM UTC-2, David Davis wrote: > > I noticed in Katello's commands, there are hyphens (e.g. hammer > lifecycle-environment create) but in the Foreman commands, there are > underscores (e.g. hammer partition_table create). I'm wondering if > we should probably use the same format? And if so, which of the two? > > David > > -- > You received this message because you are subscribed to the Google > Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send > an email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out.

–
Mike McCune
mmccune AT redhat.com
Red Hat Engineering | Portland, OR
Systems Management | 650-254-4248

#7

As an end-user of hammer, I’d say “-" is more intuitive and efficient (less keystrokes on most keyboards).

··· On 04 Feb 2014, at 19:58, Tom McKay wrote:

----- Original Message -----

From: “Bryan Kearney” bryan.kearney@gmail.com
To: foreman-dev@googlegroups.com
Sent: Tuesday, February 4, 2014 11:08:59 AM
Subject: Re: [foreman-dev] Underscores vs hyphens in hammer

On 02/04/2014 11:08 AM, David Davis wrote:

I noticed in Katello’s commands, there are hyphens (e.g. hammer
lifecycle-environment create) but in the Foreman commands, there are
underscores (e.g. hammer partition_table create). I’m wondering if we
should probably use the same format? And if so, which of the two?

David

Foreman was first, it wins :slight_smile:

– bk

It’s a bit inconsistent to use _ when all the command options get auto-generated into -.

Consistency wins over first arrival!

#8

I personally prefer underscores as they appear more readable to me. But
that's no reason. I have no problem with accepting a patch that turns it
to dashes if majority of users finds it better. I'd like to come to some
consensus before we start rewriting the code.

So, shall we vote?

T.

··· On 02/04/2014 07:58 PM, Tom McKay wrote: > > > ----- Original Message ----- >> From: "Bryan Kearney" >> To: foreman-dev@googlegroups.com >> Sent: Tuesday, February 4, 2014 11:08:59 AM >> Subject: Re: [foreman-dev] Underscores vs hyphens in hammer >> >> On 02/04/2014 11:08 AM, David Davis wrote: >>> I noticed in Katello's commands, there are hyphens (e.g. hammer >>> lifecycle-environment create) but in the Foreman commands, there are >>> underscores (e.g. hammer partition_table create). I'm wondering if we >>> should probably use the same format? And if so, which of the two? >>> >>> David >>> >> Foreman was first, it wins :) >> >> -- bk >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> > > It's a bit inconsistent to use _ when all the command options get auto-generated into -. > > Consistency wins over first arrival! >
#9

We can keep voting but it looks like there was only 1 vote for underscores and 9 or so for hyphens.

David

··· ----- Original Message ----- > From: "Mike McCune" > To: foreman-dev@googlegroups.com > Cc: "Elyézer Rezende" , daviddavis@redhat.com > Sent: Wednesday, February 5, 2014 12:54:53 PM > Subject: Re: [foreman-dev] Re: Underscores vs hyphens in hammer > > +1 > > examples: > > git-* > virt-* > system-config-* > etc .. > > $ ls /usr/bin/ |grep "\_" | wc -l > 173 > > $ ls /usr/bin/ |grep "\-" | wc -l > 805 > > > On 02/05/2014 06:43 AM, Elyézer Rezende wrote: > > Also "-" is more consistent with other command-line commands than "_". > > > > On Tuesday, February 4, 2014 2:08:27 PM UTC-2, David Davis wrote: > > > > I noticed in Katello's commands, there are hyphens (e.g. hammer > > lifecycle-environment create) but in the Foreman commands, there are > > underscores (e.g. hammer partition_table create). I'm wondering if > > we should probably use the same format? And if so, which of the two? > > > > David > > > > -- > > You received this message because you are subscribed to the Google > > Groups "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send > > an email to foreman-dev+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/groups/opt_out. > > -- > Mike McCune > mmccune AT redhat.com > Red Hat Engineering | Portland, OR > Systems Management | 650-254-4248 > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
#10

Ivan convinced me. Voted!

#11

Sure, here's a poll:

https://docs.google.com/forms/d/1ohWJ-1LFPUB60CXpirnoWmgFamDm5_QornwOwduzhS0/viewform

David

··· ----- Original Message ----- > From: "Tomas Strachota" > To: foreman-dev@googlegroups.com > Sent: Wednesday, February 5, 2014 10:02:35 AM > Subject: Re: [foreman-dev] Underscores vs hyphens in hammer > > On 02/04/2014 07:58 PM, Tom McKay wrote: > > > > > > ----- Original Message ----- > >> From: "Bryan Kearney" > >> To: foreman-dev@googlegroups.com > >> Sent: Tuesday, February 4, 2014 11:08:59 AM > >> Subject: Re: [foreman-dev] Underscores vs hyphens in hammer > >> > >> On 02/04/2014 11:08 AM, David Davis wrote: > >>> I noticed in Katello's commands, there are hyphens (e.g. hammer > >>> lifecycle-environment create) but in the Foreman commands, there are > >>> underscores (e.g. hammer partition_table create). I'm wondering if we > >>> should probably use the same format? And if so, which of the two? > >>> > >>> David > >>> > >> Foreman was first, it wins :) > >> > >> -- bk > >> > >> -- > >> You received this message because you are subscribed to the Google Groups > >> "foreman-dev" group. > >> To unsubscribe from this group and stop receiving emails from it, send an > >> email to foreman-dev+unsubscribe@googlegroups.com. > >> For more options, visit https://groups.google.com/groups/opt_out. > >> > > > > It's a bit inconsistent to use _ when all the command options get > > auto-generated into -. > > > > Consistency wins over first arrival! > > > > I personally prefer underscores as they appear more readable to me. But > that's no reason. I have no problem with accepting a patch that turns it > to dashes if majority of users finds it better. I'd like to come to some > consensus before we start rewriting the code. > > So, shall we vote? > > T. > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
#12

man git answers it for me

– Ivan

··· ----- Original Message ----- > Sure, here's a poll: > > https://docs.google.com/forms/d/1ohWJ-1LFPUB60CXpirnoWmgFamDm5_QornwOwduzhS0/viewform > > David > > ----- Original Message ----- > > From: "Tomas Strachota" > > To: foreman-dev@googlegroups.com > > Sent: Wednesday, February 5, 2014 10:02:35 AM > > Subject: Re: [foreman-dev] Underscores vs hyphens in hammer > > > > On 02/04/2014 07:58 PM, Tom McKay wrote: > > > > > > > > > ----- Original Message ----- > > >> From: "Bryan Kearney" > > >> To: foreman-dev@googlegroups.com > > >> Sent: Tuesday, February 4, 2014 11:08:59 AM > > >> Subject: Re: [foreman-dev] Underscores vs hyphens in hammer > > >> > > >> On 02/04/2014 11:08 AM, David Davis wrote: > > >>> I noticed in Katello's commands, there are hyphens (e.g. hammer > > >>> lifecycle-environment create) but in the Foreman commands, there are > > >>> underscores (e.g. hammer partition_table create). I'm wondering if we > > >>> should probably use the same format? And if so, which of the two? > > >>> > > >>> David > > >>> > > >> Foreman was first, it wins :) > > >> > > >> -- bk > > >> > > >> -- > > >> You received this message because you are subscribed to the Google > > >> Groups > > >> "foreman-dev" group. > > >> To unsubscribe from this group and stop receiving emails from it, send > > >> an > > >> email to foreman-dev+unsubscribe@googlegroups.com. > > >> For more options, visit https://groups.google.com/groups/opt_out. > > >> > > > > > > It's a bit inconsistent to use _ when all the command options get > > > auto-generated into -. > > > > > > Consistency wins over first arrival! > > > > > > > I personally prefer underscores as they appear more readable to me. But > > that's no reason. I have no problem with accepting a patch that turns it > > to dashes if majority of users finds it better. I'd like to come to some > > consensus before we start rewriting the code. > > > > So, shall we vote? > > > > T. > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >
#13

CLOSE THE POLLS!

··· ----- Original Message ----- > From: "David Davis" > To: foreman-dev@googlegroups.com > Sent: Thursday, February 6, 2014 6:33:24 AM > Subject: Re: [foreman-dev] Re: Underscores vs hyphens in hammer > > We can keep voting but it looks like there was only 1 vote for underscores > and 9 or so for hyphens. > > David > > ----- Original Message ----- > > From: "Mike McCune" > > To: foreman-dev@googlegroups.com > > Cc: "Elyézer Rezende" , daviddavis@redhat.com > > Sent: Wednesday, February 5, 2014 12:54:53 PM > > Subject: Re: [foreman-dev] Re: Underscores vs hyphens in hammer > > > > +1 > > > > examples: > > > > git-* > > virt-* > > system-config-* > > etc .. > > > > $ ls /usr/bin/ |grep "\_" | wc -l > > 173 > > > > $ ls /usr/bin/ |grep "\-" | wc -l > > 805 > > > > > > On 02/05/2014 06:43 AM, Elyézer Rezende wrote: > > > Also "-" is more consistent with other command-line commands than "_". > > > > > > On Tuesday, February 4, 2014 2:08:27 PM UTC-2, David Davis wrote: > > > > > > I noticed in Katello's commands, there are hyphens (e.g. hammer > > > lifecycle-environment create) but in the Foreman commands, there are > > > underscores (e.g. hammer partition_table create). I'm wondering if > > > we should probably use the same format? And if so, which of the two? > > > > > > David > > > > > > -- > > > You received this message because you are subscribed to the Google > > > Groups "foreman-dev" group. > > > To unsubscribe from this group and stop receiving emails from it, send > > > an email to foreman-dev+unsubscribe@googlegroups.com. > > > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > > Mike McCune > > mmccune AT redhat.com > > Red Hat Engineering | Portland, OR > > Systems Management | 650-254-4248 > > > > -- > > You received this message because you are subscribed to the Google Groups > > "foreman-dev" group. > > To unsubscribe from this group and stop receiving emails from it, send an > > email to foreman-dev+unsubscribe@googlegroups.com. > > For more options, visit https://groups.google.com/groups/opt_out. > > > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >

–

  • adam price
#14

Results are quite clear. Close it, please.

I created 2 new issues for that:
http://projects.theforeman.org/issues/4291
http://projects.theforeman.org/issues/4292

T.

··· On 02/06/2014 02:56 PM, Adam Price wrote: > CLOSE THE POLLS! > > ----- Original Message ----- >> From: "David Davis" >> To: foreman-dev@googlegroups.com >> Sent: Thursday, February 6, 2014 6:33:24 AM >> Subject: Re: [foreman-dev] Re: Underscores vs hyphens in hammer >> >> We can keep voting but it looks like there was only 1 vote for underscores >> and 9 or so for hyphens. >> >> David >> >> ----- Original Message ----- >> > From: "Mike McCune" >> > To: foreman-dev@googlegroups.com >> > Cc: "Elyézer Rezende" , daviddavis@redhat.com >> > Sent: Wednesday, February 5, 2014 12:54:53 PM >> > Subject: Re: [foreman-dev] Re: Underscores vs hyphens in hammer >> > >> > +1 >> > >> > examples: >> > >> > git-* >> > virt-* >> > system-config-* >> > etc .. >> > >> > $ ls /usr/bin/ |grep "\_" | wc -l >> > 173 >> > >> > $ ls /usr/bin/ |grep "\-" | wc -l >> > 805 >> > >> > >> > On 02/05/2014 06:43 AM, Elyézer Rezende wrote: >> > > Also "-" is more consistent with other command-line commands than "_". >> > > >> > > On Tuesday, February 4, 2014 2:08:27 PM UTC-2, David Davis wrote: >> > > >> > > I noticed in Katello's commands, there are hyphens (e.g. hammer >> > > lifecycle-environment create) but in the Foreman commands, there are >> > > underscores (e.g. hammer partition_table create). I'm wondering if >> > > we should probably use the same format? And if so, which of the two? >> > > >> > > David >> > > >> > > -- >> > > You received this message because you are subscribed to the Google >> > > Groups "foreman-dev" group. >> > > To unsubscribe from this group and stop receiving emails from it, send >> > > an email to foreman-dev+unsubscribe@googlegroups.com. >> > > For more options, visit https://groups.google.com/groups/opt_out. >> > >> > -- >> > Mike McCune >> > mmccune AT redhat.com >> > Red Hat Engineering | Portland, OR >> > Systems Management | 650-254-4248 >> > >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "foreman-dev" group. >> > To unsubscribe from this group and stop receiving emails from it, send an >> > email to foreman-dev+unsubscribe@googlegroups.com. >> > For more options, visit https://groups.google.com/groups/opt_out. >> > >> >> -- >> You received this message because you are subscribed to the Google Groups >> "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to foreman-dev+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/groups/opt_out. >> >