Upcoming Rails 4 branch merge

>
> > >> > The "Test failures on Ruby 2.2" ticket at
> > >> > Bug #12219: Test failures on Ruby 2.2 - Foreman must be fixed too so
that
> > >> > 2.2 can be added to our test matrix and we can package safely
against
> > >> > that version.
> > >> >
> > > I’ll pick it up. Two failures around skipped tests are easy to deal
> > > with; will see what the hostname failure is about.
> >
> > Thanks Dmitri. The failure on PostgreSQL loading the library version is
> > also rather concerning, but it seemed very consistent. I haven't tried
> > to reproduce it locally yet, so shout if you struggle to do so.
>
> I can't reproduce that bug anymore, on the Rails 4 branch tests on
postgres
> & Ruby 2.2 seem to pass just like the rest.
>
> —
>
> Last thursday we had a call with Katello developers working on Rails 4
> as well and it seems like all major projects should be ready. The PR in
> core https://github.com/theforeman/foreman/pull/2870 passes w/o the
> memory issues it used to have, and Katello seems to be consistently
> green as well.
>
> We proposed Tuesday Dec 15th as the merge day, the reason being that
> right now it can be merged, and delaying it more means delaying other
> big features coming in such as facets or Patternfly.
>
> Not to mention maintaining the rails4 branch and all projects passing
> tests in sync is a burden on some developers that we can get rid of
> quickly after merging.
>
> Third, the sooner we get this in, the more testing it will get before
> 1.11. I will move my local 'production' foreman to nightly to iron out
> possible common bugs :slight_smile:
>
> Does that sound good, is there anything anyone would like to do before
> merging, etc? If not, let's not merge any major changes on Monday and
> let's tackle this on Tuesday asap. Is there anyone that can merge Rails
> 4 on Katello in any European timezone?
>

No, but we could coordinate to work earlier EST to maximize crossover
between all developers to address any issues.

>
> –
> Daniel Lobato Garcia
>
> @dLobatog
> blog.daniellobato.me
> daniellobato.me
>
> GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
> Keybase: https://keybase.io/elobato
>
> –
> You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.

··· On Dec 12, 2015 12:18 PM, "Daniel Lobato Garcia" wrote: > On 11/11, Dominic Cleal wrote: > > On 11/11/15 12:19, Dmitri Dolguikh wrote: > > > On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal wrote: > For more options, visit https://groups.google.com/d/optout.

> > >> > The "Test failures on Ruby 2.2" ticket at
> > >> > Bug #12219: Test failures on Ruby 2.2 - Foreman must be fixed too so
> that
> > >> > 2.2 can be added to our test matrix and we can package safely
> against
> > >> > that version.
> > >> >
> > > I’ll pick it up. Two failures around skipped tests are easy to deal
> > > with; will see what the hostname failure is about.
> >
> > Thanks Dmitri. The failure on PostgreSQL loading the library version is
> > also rather concerning, but it seemed very consistent. I haven't tried
> > to reproduce it locally yet, so shout if you struggle to do so.
>
> I can't reproduce that bug anymore, on the Rails 4 branch tests on postgres
> & Ruby 2.2 seem to pass just like the rest.
>
> —
>
> Last thursday we had a call with Katello developers working on Rails 4
> as well and it seems like all major projects should be ready. The PR in
> core https://github.com/theforeman/foreman/pull/2870 passes w/o the
> memory issues it used to have, and Katello seems to be consistently
> green as well.
>
> We proposed Tuesday Dec 15th as the merge day, the reason being that
> right now it can be merged, and delaying it more means delaying other
> big features coming in such as facets or Patternfly.
>
> Not to mention maintaining the rails4 branch and all projects passing
> tests in sync is a burden on some developers that we can get rid of
> quickly after merging.
>
> Third, the sooner we get this in, the more testing it will get before
> 1.11. I will move my local 'production' foreman to nightly to iron out
> possible common bugs :slight_smile:
>
> Does that sound good?

+1

Ohad

··· On Sat, Dec 12, 2015 at 7:18 PM, Daniel Lobato Garcia wrote: > On 11/11, Dominic Cleal wrote: > > On 11/11/15 12:19, Dmitri Dolguikh wrote: > > > On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal > wrote:

is there anything anyone would like to do before
merging, etc? If not, let’s not merge any major changes on Monday and
let’s tackle this on Tuesday asap. Is there anyone that can merge Rails
4 on Katello in any European timezone?


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

I don’t know if I would feel comfortable merging the Rails 4 PR on Katello
but I am in GMT+1 and happy to help out with anything.

David

··· On Sat, Dec 12, 2015 at 6:18 PM, Daniel Lobato Garcia wrote:

On 11/11, Dominic Cleal wrote:

On 11/11/15 12:19, Dmitri Dolguikh wrote:

On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal dominic@cleal.org > wrote:

The “Test failures on Ruby 2.2” ticket at
Bug #12219: Test failures on Ruby 2.2 - Foreman must be fixed too so
that

2.2 can be added to our test matrix and we can package safely
against

that version.

I’ll pick it up. Two failures around skipped tests are easy to deal
with; will see what the hostname failure is about.

Thanks Dmitri. The failure on PostgreSQL loading the library version is
also rather concerning, but it seemed very consistent. I haven’t tried
to reproduce it locally yet, so shout if you struggle to do so.

I can’t reproduce that bug anymore, on the Rails 4 branch tests on postgres
& Ruby 2.2 seem to pass just like the rest.


Last thursday we had a call with Katello developers working on Rails 4
as well and it seems like all major projects should be ready. The PR in
core https://github.com/theforeman/foreman/pull/2870 passes w/o the
memory issues it used to have, and Katello seems to be consistently
green as well.

We proposed Tuesday Dec 15th as the merge day, the reason being that
right now it can be merged, and delaying it more means delaying other
big features coming in such as facets or Patternfly.

Not to mention maintaining the rails4 branch and all projects passing
tests in sync is a burden on some developers that we can get rid of
quickly after merging.

Third, the sooner we get this in, the more testing it will get before
1.11. I will move my local ‘production’ foreman to nightly to iron out
possible common bugs :slight_smile:

Does that sound good, is there anything anyone would like to do before
merging, etc? If not, let’s not merge any major changes on Monday and
let’s tackle this on Tuesday asap. Is there anyone that can merge Rails
4 on Katello in any European timezone?


Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

>>>>> The "Test failures on Ruby 2.2" ticket at
>>>>> Bug #12219: Test failures on Ruby 2.2 - Foreman must be fixed too so that
>>>>> 2.2 can be added to our test matrix and we can package safely against
>>>>> that version.
>>>>>
>>> I’ll pick it up. Two failures around skipped tests are easy to deal
>>> with; will see what the hostname failure is about.
>>
>> Thanks Dmitri. The failure on PostgreSQL loading the library version is
>> also rather concerning, but it seemed very consistent. I haven't tried
>> to reproduce it locally yet, so shout if you struggle to do so.
>
> I can't reproduce that bug anymore, on the Rails 4 branch tests on postgres
> & Ruby 2.2 seem to pass just like the rest.

The PostgreSQL test appears to still fail with a vaguely similar error:

  • bundle exec rake db:drop db:create db:migrate
    Could not load 'active_record/connection_adapters/postgresql_adapter'.
    Make sure that the adapter in config/database.yml is valid. If you use
    an adapter other than 'mysql', 'mysql2', 'postgresql' or 'sqlite3' add
    the necessary adapter gem to the Gemfile.
    /usr/local/rvm/gems/ruby-2.2.3@test_develop_pr_core_ruby22-1/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:247:in
    `require'

(http://ci.theforeman.org/job/test_develop_pr_core_ruby22/8/database=postgresql,ruby=2.2/console)

The three test case failures are gone on your Rails 4 branch.

> Last thursday we had a call with Katello developers working on Rails 4
> as well and it seems like all major projects should be ready. The PR in
> core https://github.com/theforeman/foreman/pull/2870 passes w/o the
> memory issues it used to have, and Katello seems to be consistently
> green as well.
>
> We proposed Tuesday Dec 15th as the merge day, the reason being that
> right now it can be merged, and delaying it more means delaying other
> big features coming in such as facets or Patternfly.
>
> Not to mention maintaining the rails4 branch and all projects passing
> tests in sync is a burden on some developers that we can get rid of
> quickly after merging.
>
> Third, the sooner we get this in, the more testing it will get before
> 1.11. I will move my local 'production' foreman to nightly to iron out
> possible common bugs :slight_smile:
>
> Does that sound good, is there anything anyone would like to do before
> merging, etc? If not, let's not merge any major changes on Monday and
> let's tackle this on Tuesday asap. Is there anyone that can merge Rails
> 4 on Katello in any European timezone?

The review isn't complete, I'll only be merging it when that's done. I
also won't do it at the same time as the 1.10.0 release to ensure one
doesn't disrupt the other.

1.10.0 has got another important ticket (#12794) assigned and in
progress, but I really hope it will be sorted in the next day or two.

··· On 12/12/15 17:18, Daniel Lobato Garcia wrote: > On 11/11, Dominic Cleal wrote: >> On 11/11/15 12:19, Dmitri Dolguikh wrote: >>> On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal wrote:


Dominic Cleal
dominic@cleal.org

What versions of Ruby will be supported/tested against once this work is
merged? I am not familiar with the Debian side of available Rails versions.

Eric

··· On Mon, Dec 14, 2015 at 8:00 AM, Dominic Cleal wrote:

On 12/12/15 17:18, Daniel Lobato Garcia wrote:

On 11/11, Dominic Cleal wrote:

On 11/11/15 12:19, Dmitri Dolguikh wrote:

On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal dominic@cleal.org > wrote:

The “Test failures on Ruby 2.2” ticket at
Bug #12219: Test failures on Ruby 2.2 - Foreman must be fixed too so
that

2.2 can be added to our test matrix and we can package safely against
that version.

I’ll pick it up. Two failures around skipped tests are easy to deal
with; will see what the hostname failure is about.

Thanks Dmitri. The failure on PostgreSQL loading the library version is
also rather concerning, but it seemed very consistent. I haven’t tried
to reproduce it locally yet, so shout if you struggle to do so.

I can’t reproduce that bug anymore, on the Rails 4 branch tests on
postgres
& Ruby 2.2 seem to pass just like the rest.

The PostgreSQL test appears to still fail with a vaguely similar error:

  • bundle exec rake db:drop db:create db:migrate
    Could not load ‘active_record/connection_adapters/postgresql_adapter’.
    Make sure that the adapter in config/database.yml is valid. If you use
    an adapter other than ‘mysql’, ‘mysql2’, ‘postgresql’ or ‘sqlite3’ add
    the necessary adapter gem to the Gemfile.
    /usr/local/rvm/gems/ruby-2.2.3@test_develop_pr_core_ruby22-1
    /gems/activesupport-4.1.5/lib/active_support/dependencies.rb:247:in
    `require’

(
http://ci.theforeman.org/job/test_develop_pr_core_ruby22/8/database=postgresql,ruby=2.2/console
)

The three test case failures are gone on your Rails 4 branch.

Last thursday we had a call with Katello developers working on Rails 4
as well and it seems like all major projects should be ready. The PR in
core https://github.com/theforeman/foreman/pull/2870 passes w/o the
memory issues it used to have, and Katello seems to be consistently
green as well.

We proposed Tuesday Dec 15th as the merge day, the reason being that
right now it can be merged, and delaying it more means delaying other
big features coming in such as facets or Patternfly.

Not to mention maintaining the rails4 branch and all projects passing
tests in sync is a burden on some developers that we can get rid of
quickly after merging.

Third, the sooner we get this in, the more testing it will get before
1.11. I will move my local ‘production’ foreman to nightly to iron out
possible common bugs :slight_smile:

Does that sound good, is there anything anyone would like to do before
merging, etc? If not, let’s not merge any major changes on Monday and
let’s tackle this on Tuesday asap. Is there anyone that can merge Rails
4 on Katello in any European timezone?

The review isn’t complete, I’ll only be merging it when that’s done. I
also won’t do it at the same time as the 1.10.0 release to ensure one
doesn’t disrupt the other.

1.10.0 has got another important ticket (#12794) assigned and in
progress, but I really hope it will be sorted in the next day or two.


Dominic Cleal
dominic@cleal.org


You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.


Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University

> What versions of Ruby will be supported/tested against once this work is
> merged?

The Rails PR doesn't change the supported Ruby versions, so it's
unchanged from 1.9.3, 2.0.0 and 2.1.

Once #12219 is fixed, then Ruby 2.2 can also be tested and supported.

> I am not familiar with the Debian side of available Rails versions.

Debian packages use the Rails version specified in the Gemfile, via a
vendored directory of gems. They use a range of Ruby versions from
1.9.3 to 2.1, depending on the release. #8884 tracks (eventually)
dropping Ruby 1.9.3 support.

··· On 14/12/15 15:55, Eric D Helms wrote:


Dominic Cleal
dominic@cleal.org

I tried installing 2.2.3 and 2.2.2, then running the very same command
jenkins runs (bundle exec rake db:drop db:create db:migrate) and it
worked without any problems.

Not saying it's this, but somebody with a similar problem on
stackoverflow solved the issue by reinstalling that ruby version, whose
gemset might have been corrupted.

··· > On 11/11, Dominic Cleal wrote: > >> On 11/11/15 12:19, Dmitri Dolguikh wrote: > >>> On Wed, Nov 11, 2015 at 12:10 PM, Dominic Cleal wrote: > >>>>> The "Test failures on Ruby 2.2" ticket at > >>>>> http://projects.theforeman.org/issues/12219 must be fixed too so that > >>>>> 2.2 can be added to our test matrix and we can package safely against > >>>>> that version. > > > I can't reproduce that bug anymore, on the Rails 4 branch tests on postgres > > & Ruby 2.2 seem to pass just like the rest. > > The PostgreSQL test appears to still fail with a vaguely similar error: > > + bundle exec rake db:drop db:create db:migrate > Could not load 'active_record/connection_adapters/postgresql_adapter'. > Make sure that the adapter in config/database.yml is valid. If you use > an adapter other than 'mysql', 'mysql2', 'postgresql' or 'sqlite3' add > the necessary adapter gem to the Gemfile. > /usr/local/rvm/gems/ruby-2.2.3@test_develop_pr_core_ruby22-1/gems/activesupport-4.1.5/lib/active_support/dependencies.rb:247:in > `require' > > (http://ci.theforeman.org/job/test_develop_pr_core_ruby22/8/database=postgresql,ruby=2.2/console)


Daniel Lobato Garcia

@dLobatog

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: elobato (Daniel Lobato Garcia) | Keybase

Katello rails 4 is ready to merge.

All tests passing. Compatible with ruby 1.9.3, 2.0.x, 2.1.x, and 2.2.x

We are ready to coordinate with the foreman core devs to merge in tandem.

Thanks,
Chris

··· On Monday, December 14, 2015 at 11:01:35 AM UTC-5, Dominic Cleal wrote: > > On 14/12/15 15:55, Eric D Helms wrote: > > What versions of Ruby will be supported/tested against once this work is > > merged? > > The Rails PR doesn't change the supported Ruby versions, so it's > unchanged from 1.9.3, 2.0.0 and 2.1. > > Once #12219 is fixed, then Ruby 2.2 can also be tested and supported. > > > I am not familiar with the Debian side of available Rails versions. > > Debian packages use the Rails version specified in the Gemfile, via a > vendored directory of gems. They use a range of Ruby versions from > 1.9.3 to 2.1, depending on the release. #8884 tracks (eventually) > dropping Ruby 1.9.3 support. > > -- > Dominic Cleal > dom...@cleal.org >

> Katello rails 4 is ready to merge.
>
> All tests passing. Compatible with ruby 1.9.3, 2.0.x, 2.1.x, and 2.2.x
>
> We are ready to coordinate with the foreman core devs to merge in tandem.
>
> great news!

Thanks,

··· On Wed, Dec 16, 2015 at 12:03 AM, wrote: > Chris > > On Monday, December 14, 2015 at 11:01:35 AM UTC-5, Dominic Cleal wrote: >> >> On 14/12/15 15:55, Eric D Helms wrote: >> > What versions of Ruby will be supported/tested against once this work >> is >> > merged? >> >> The Rails PR doesn't change the supported Ruby versions, so it's >> unchanged from 1.9.3, 2.0.0 and 2.1. >> >> Once #12219 is fixed, then Ruby 2.2 can also be tested and supported. >> >> > I am not familiar with the Debian side of available Rails versions. >> >> Debian packages use the Rails version specified in the Gemfile, via a >> vendored directory of gems. They use a range of Ruby versions from >> 1.9.3 to 2.1, depending on the release. #8884 tracks (eventually) >> dropping Ruby 1.9.3 support. >> >> -- >> Dominic Cleal >> dom...@cleal.org >> > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >