We've spoken before about increasing the pool of reviewers, and one issue
is the increasingly large amount of notification email (especially if you
subscribe to a lot of our repos).
So I was browsing some other repos today and stumbled upon this:
It's basically a tool to figure out who might be good reviewers for a pull
request, and mention them by name so that they get a notification. This
allows people to get a heads-up on repos they're not subscribed to, but
have contributed to.
Worth enabling on a few repos and giving it a try?
> We've spoken before about increasing the pool of reviewers, and one issue
> is the increasingly large amount of notification email (especially if you
> subscribe to a lot of our repos).
>
> So I was browsing some other repos today and stumbled upon this:
>
> https://github.com/facebook/mention-bot
>
> It's basically a tool to figure out who might be good reviewers for a pull
> request, and mention them by name so that they get a notification. This
> allows people to get a heads-up on repos they're not subscribed to, but
> have contributed to.
>
> Worth enabling on a few repos and giving it a try?
>
+1 I'm all for experimentation. If it doesn't work or is annoying we can
always shut'er down.
Eric
···
On Tue, Oct 11, 2016 at 11:15 AM, Greg Sutcliffe wrote:
We’ve spoken before about increasing the pool of reviewers, and one issue
is the increasingly large amount of notification email (especially if you
subscribe to a lot of our repos).
So I was browsing some other repos today and stumbled upon this:
It’s basically a tool to figure out who might be good reviewers for a
pull request, and mention them by name so that they get a notification.
This allows people to get a heads-up on repos they’re not subscribed to,
but have contributed to.
Worth enabling on a few repos and giving it a try?
+1 I’m all for experimentation. If it doesn’t work or is annoying we can
always shut’er down.
> We've spoken before about increasing the pool of reviewers, and one issue
> is the increasingly large amount of notification email (especially if you
> subscribe to a lot of our repos).
>
> So I was browsing some other repos today and stumbled upon this:
>
> https://github.com/facebook/mention-bot
>
> It's basically a tool to figure out who might be good reviewers for a pull
> request, and mention them by name so that they get a notification. This
> allows people to get a heads-up on repos they're not subscribed to, but
> have contributed to.
>
> Worth enabling on a few repos and giving it a try?
+1 from me - there's always time to shut it down if it doesn't help
I'll enable on Katello tomorrow so devs have at least a days notice that it
will be turned on.
···
On Wed, Oct 12, 2016 at 10:09 AM, Greg Sutcliffe wrote:
Sounds positive so far - which repos should we try it on? I’m thinking
core, proxy, katello and the website for now? We can put it everywhere if
that goes well.
I don’t think I have the rights to enable it though, so I’ll need someone
to volunteer to do that
Sounds positive so far - which repos should we try it on? I'm thinking
core, proxy, katello and the website for now? We can put it everywhere if
that goes well.
I don't think I have the rights to enable it though, so I'll need someone
to volunteer to do that
> Sounds positive so far - which repos should we try it on? I'm thinking
> core, proxy, katello and the website for now? We can put it everywhere if
> that goes well.
I love this bot, I already know that in advance.
I'd scratch the website tho, the three would be a good start.
I put the website because quite a few new contributors start there, with
small doc fixes - thus it has a higher number of people for the bot to
ping. Might be interesting to see it's heuristics in action. But I don't
mind either way
Greg
···
On 12 October 2016 at 16:29, Lukas Zapletal wrote:
Sounds positive so far - which repos should we try it on? I’m thinking
core, proxy, katello and the website for now? We can put it everywhere if
that goes well.
I love this bot, I already know that in advance.
I’d scratch the website tho, the three would be a good start.
···
On Wed, Oct 12, 2016 at 11:57 AM, Greg Sutcliffe wrote:
On 12 October 2016 at 16:29, Lukas Zapletal lzap@redhat.com wrote:
Sounds positive so far - which repos should we try it on? I’m thinking
core, proxy, katello and the website for now? We can put it everywhere
if
that goes well.
I love this bot, I already know that in advance.
I’d scratch the website tho, the three would be a good start.
I put the website because quite a few new contributors start there, with
small doc fixes - thus it has a higher number of people for the bot to
ping. Might be interesting to see it’s heuristics in action. But I don’t
mind either way
Irgendwann am Wed, Oct 12, 2016 um 04:57:35PM +0100, schrieb Greg Sutcliffe:
>
> > > Sounds positive so far - which repos should we try it on? I'm thinking
> > > core, proxy, katello and the website for now? We can put it everywhere if
> > > that goes well.
> >
> > I love this bot, I already know that in advance.
> >
> > I'd scratch the website tho, the three would be a good start.
> >
>
> I put the website because quite a few new contributors start there, with
> small doc fixes - thus it has a higher number of people for the bot to
+1 to that.
> ping. Might be interesting to see it's heuristics in action. But I don't
> mind either way
I agree, would be interesting to see it in action.
Anurag
···
> On 12 October 2016 at 16:29, Lukas Zapletal wrote:
>
>> This has been turned on for the Katello repo, if devs find it needs
>> tweaking there is a configuration file that can be added (
>> https://github.com/facebook/mention-bot#configuration).
>>
>
> How's that going for you?
>
> Dominic or Ohad, could you turn it on for the other repos mentioned, as a
> trial? Thanks!
>
Done.
Ohad
···
On Mon, Oct 17, 2016 at 4:02 PM, Greg Sutcliffe wrote:
> On 13 October 2016 at 13:28, Eric D Helms wrote:
+1, I'm failing to get time for reviews and this does not help me, but I'm ok
with it pinging me if it helps others.
···
On úterý 6. prosince 2016 12:37:23 CET Daniel Lobato Garcia wrote:
> On 12/06, Sean O'Keeffe wrote:
> > Hows this going for everybody? I personally quite like it
>
> Personally it's just noise for me, but if it works for some people it
> causes no harm
Dominic or Ohad, could you turn it on for the other repos
mentioned,
as
a trial? Thanks!
Done.
Thanks. It’s already pinged me for a review, so that was cool.
Lets see how it goes for a few weeks and we can see if we want to
expand
to other repos. Feedback welcome as we go
Greg
–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send
>>> Hows this going for everybody? I personally quite like it
>> Personally it's just noise for me, but if it works for some people it
>> causes no harm
> +1, I'm failing to get time for reviews and this does not help me, but I'm ok
> with it pinging me if it helps others.
Not super useful for me either and I don't feel like its helping draw
more people in to review on katello/katello. But it doesn't bother if
others enjoy it.
···
On 12/06/2016 01:11 PM, Marek Hulán wrote:
> On úterý 6. prosince 2016 12:37:23 CET Daniel Lobato Garcia wrote:
>> On 12/06, Sean O'Keeffe wrote:
Dominic or Ohad, could you turn it on for the other repos mentioned,
as
a trial? Thanks!
Done.
Thanks. It’s already pinged me for a review, so that was cool.
Lets see how it goes for a few weeks and we can see if we want to expand
to other repos. Feedback welcome as we go
I have a gmail filter for mentions with a folder. This does help draw some
attention to reviews for me given I use it that way as I tend to prioritize
that folder.
···
On Wed, Dec 7, 2016 at 8:39 AM, Justin Sherrill wrote:
On 12/06/2016 01:11 PM, Marek Hulán wrote:
On úterý 6. prosince 2016 12:37:23 CET Daniel Lobato Garcia wrote:
On 12/06, Sean O’Keeffe wrote:
Hows this going for everybody? I personally quite like it
Personally it’s just noise for me, but if it works for some people it
causes no harm
+1, I’m failing to get time for reviews and this does not help me, but
I’m ok
with it pinging me if it helps others.
Not super useful for me either and I don’t feel like its helping draw
more people in to review on katello/katello. But it doesn’t bother if
others enjoy it.
–
Marek
On Fri, Oct 28, 2016 at 12:36 PM, Greg Sutcliffe > >>> greg.sutcliffe@gmail.com > >>> > >>> wrote:
Dominic or Ohad, could you turn it on for the other repos mentioned,
as
a trial? Thanks!
Done.
Thanks. It’s already pinged me for a review, so that was cool.
Lets see how it goes for a few weeks and we can see if we want to
expand
to other repos. Feedback welcome as we go
Greg
–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send
an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
You received this message because you are subscribed to the Google
Groups
Dominic or Ohad, could you turn it on for the other repos
mentioned,
as
a trial? Thanks!
Done.
Thanks. It’s already pinged me for a review, so that was cool.
Lets see how it goes for a few weeks and we can see if we want to
expand
to other repos. Feedback welcome as we go
Greg
–
You received this message because you are subscribed to the Google
Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it,
send