Foreman just added HoundCI [1] to their project to lint code and I’d like
to open a discussion around trying out HoundCI on Katello for rubocop
linting. It would basically be the same as how we currently lint ruby code
in Jenkins, however, HoundCI would run outside of Jenkins and leaves inline
comments (see https://github.com/theforeman/foreman/pull/3766).
I think the main advantage of using HoundCI would be that it frees up
overburdened Jenkins resources. Plus, we could use it for other things in
the future like linting our CSS/JS code. Conversely, the main disadvantage
I see is having inline PR comments which can create a lot of noise—and I
think one of the main reasons we started using rubocop was to reduce the PR
noise of developers commenting on style.
Unless people disagree, I’d propose is that we try it out on our main
katello project for a couple weeks starting on August 30th (and leave the
Jenkins rubocop job in place but perhaps disable it). After this initial
trial period, we could then evaluate based on feedback whether we’d like to
continue using it.
Before we enable HoundCI, you may want to set up email filters to filter
out emails from "Hound <notifications@github.com>” (assuming that you have
github email notifications enabled). Also, you’ll need to be aware that
you’ll see an increased number of comments in PRs once HoundCI goes live.
Anyway, I’m interested in people’s thoughts/opinions around trying out
HoundCI and using HoundCI in general.
Thanks.
[1] https://houndci.com/
David
Today we enabled HoundCI on the katello core repository. To make sure that
HoundCI properly checks your PR, please rebase against master. Your
branch should have a .hound.yml file or else HoundCI will use its default
config (which differs from ours).
Also, we’re trying this out over the next couple weeks so please respond to
this thread with any feedback or thoughts you have on using HoundCI.
Thanks.
David
···
On Tue, Aug 23, 2016 at 10:40 AM, David Davis wrote:
Foreman just added HoundCI [1] to their project to lint code and I’d like
to open a discussion around trying out HoundCI on Katello for rubocop
linting. It would basically be the same as how we currently lint ruby code
in Jenkins, however, HoundCI would run outside of Jenkins and leaves inline
comments (see https://github.com/theforeman/foreman/pull/3766).
I think the main advantage of using HoundCI would be that it frees up
overburdened Jenkins resources. Plus, we could use it for other things in
the future like linting our CSS/JS code. Conversely, the main disadvantage
I see is having inline PR comments which can create a lot of noise—and I
think one of the main reasons we started using rubocop was to reduce the PR
noise of developers commenting on style.
Unless people disagree, I’d propose is that we try it out on our main
katello project for a couple weeks starting on August 30th (and leave the
Jenkins rubocop job in place but perhaps disable it). After this initial
trial period, we could then evaluate based on feedback whether we’d like to
continue using it.
Before we enable HoundCI, you may want to set up email filters to filter
out emails from "Hound notifications@github.com” (assuming that you
have github email notifications enabled). Also, you’ll need to be aware
that you’ll see an increased number of comments in PRs once HoundCI goes
live.
Anyway, I’m interested in people’s thoughts/opinions around trying out
HoundCI and using HoundCI in general.
Thanks.
[1] https://houndci.com/
David
