If you update the contents of a PR that I'm reviewing, I'd really
appreciate it if you can a comment to say what's changed. It's hard to
tell what's been fixed and what needs doing still.
If any comments have been resolved, reply to say so. If some comments
are unfixed, or there are open tasks you're aware of, you may want to
add a checklist to the description of the PR
(https://help.github.com/articles/writing-on-github/#task-lists).
When just rebasing a branch rather than fixing things, consider leaving
a comment so we can put the "Waiting on contributor" label back until
the issues are resolved. (The repo hook on push resets the label to
needs review, which is misleading.)
Bumping this thread – I have seen an increase in this but also a lack of
it in certain areas. As a reviewer, having comments from the author when
it's updated is very helpful and makes reviewing more efficient. Developers
please re-read, and if you are already practicing please ignore. If you are
not, then please start working at it.
Thanks,
Eric
···
On Thu, Jun 11, 2015 at 5:24 AM, Dominic Cleal wrote:
If you update the contents of a PR that I’m reviewing, I’d really
appreciate it if you can a comment to say what’s changed. It’s hard to
tell what’s been fixed and what needs doing still.
If any comments have been resolved, reply to say so. If some comments
are unfixed, or there are open tasks you’re aware of, you may want to
add a checklist to the description of the PR
(https://help.github.com/articles/writing-on-github/#task-lists).
When just rebasing a branch rather than fixing things, consider leaving
a comment so we can put the “Waiting on contributor” label back until
the issues are resolved. (The repo hook on push resets the label to
needs review, which is misleading.)
Taking the opportunity here to say that if you're submitting a PR,
please spare 10 minutes to read through your own PR, find which areas
are hard to understand and comment on it inline. It makes the process
much faster in my experience.
I'll gather these comments here -
···
On 11/16, Eric D Helms wrote:
> Bumping this thread -- I have seen an increase in this but also a lack of
> it in certain areas. As a reviewer, having comments from the author when
> it's updated is very helpful and makes reviewing more efficient. Developers
> please re-read, and if you are already practicing please ignore. If you are
> not, then please start working at it.
>
> Thanks,
> Eric
>
> On Thu, Jun 11, 2015 at 5:24 AM, Dominic Cleal wrote:
>
> > If you update the contents of a PR that I'm reviewing, I'd really
> > appreciate it if you can a comment to say what's changed. It's hard to
> > tell what's been fixed and what needs doing still.
> >
> > If any comments have been resolved, reply to say so. If some comments
> > are unfixed, or there are open tasks you're aware of, you may want to
> > add a checklist to the description of the PR
> > (https://help.github.com/articles/writing-on-github/#task-lists).
> >
> > When just rebasing a branch rather than fixing things, consider leaving
> > a comment so we can put the "Waiting on contributor" label back until
> > the issues are resolved. (The repo hook on push resets the label to
> > needs review, which is misleading.)
> >
> > Thanks!
> >
> > --
> > Dominic Cleal
> > Red Hat Engineering
> >
> > --
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
>
>
> --
> Eric D. Helms
> Red Hat Engineering
> Ph.D. Student - North Carolina State University
>
> --
> You received this message because you are subscribed to the Google Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
