Add support for ec2 tags during instance creation

Development
1

Background
Currently, I am working on a feature to add support for EC2 tags.
Initially work started by a contributor and PR is opened - https://github.com/theforeman/foreman/pull/7154
With current changes it supports below things -

  • User will able to add Tags for a host
  • Before submitting new host form, user will able to remove existing tags
  • After host creation, user will be able to see the tags but won’t be able to remove/add from Host Form

I have shared current screenshots on pull-request and sharing here as well. As it involves UI changes as well on Host form, any suggestions to improve user experience better or is this ok for a first version?

  1. New host form -

    new_tag_form
    new_tag_form1464×824 39.1 KB

  2. Add/Remove tags under Hosts > New > Virtual Machine Tab

    add_more_tags
    add_more_tags1529×861 40.9 KB

  3. Disabled Tags on host edit Form

    edit_host_form_with_tags
    edit_host_form_with_tags1625×915 60.3 KB

What do you think?

1 Like
2

Well I’d add a note or icon alongside those grayed tag fields with information they cannot be edited and a host must be created from scratch of they can be edited in AWS directly. This is not a big deal, we have the same for many other fields on other CRs.

Does this also need an API change? This is definitely an useful addition and CLI users might want to use as well.

1 Like
3

Thank you @lzap for inputs.

+1 surely, I will add this.

As it comes under vm’s compute_attributes, API change may not be required but I will confirm this again.
For tracking CLI changes, created - Feature #30020: Add support for ec2 tags during instance creation - Hammer CLI - Foreman
I do need to mention tags format in a documentation for API use.

1 Like