As a katello+foreman user, I also (advice to) execute various rake scripts (clean tasks, katello refresh repos,…). And sometimes I forget to use COMMIT=true argument to really execute the script. Then it takes some time to realize why my intervention did not help, which is tedious.
Could be the COMMIT argument unified among freman+katello rake scripts?
So far I am aware of just three locations of the argument with default False, all in katello:
- https://github.com/Katello/katello/blob/295c71a5c8a6fe7f216e7723ef0598afabcb0367/lib/katello/tasks/repository.rake#L53 (used by a few scripts inside)
- https://github.com/Katello/katello/blob/ea9570ae2e2529b54f20f113abdab86b83371040/lib/katello/tasks/clean_published_repo_directories.rake#L2
- https://github.com/Katello/katello/blob/ba26191bbcdaf576c88c139794afff4f93212a21/lib/katello/tasks/clean_backend_objects.rake#L2
I understand that changing the default behaviour from “no-op” to “really-op” can be a backward-compatibility concern, though.