Base64 SVG archaeology

Development
#1

An issue that's been annoying me lately was bullet points appearing in
production mode on the dashboard, next to the widgets on the grid.

http://projects.theforeman.org/issues/7487

It seems that this was caused by some inadvertent UTF-8 in our charts
and gridster.scss files, which wasn't declared with @charset.

To help you find them, look at these lines, half way along:


Clearly it was meant to contain a bit more data at that point! I don't
know what encoded SVG image these base64 strings are meant to represent,
and would appreciate any ideas. Or perhaps somebody can forward this
along to Amos, in case he remembers the intent.

Cheers,

··· -- Dominic Cleal Red Hat Engineering
#2

> An issue that's been annoying me lately was bullet points appearing in
> production mode on the dashboard, next to the widgets on the grid.
>
> Bug #7487: Bullet points visible next to dashboard widgets - Foreman
>
> It seems that this was caused by some inadvertent UTF-8 in our charts
> and gridster.scss files, which wasn't declared with @charset.
>
> To help you find them, look at these lines, half way along:
>
> https://github.com/theforeman/foreman/blob/1.7.0-RC2/app/assets/stylesheets/gridster.scss#L173
>
> https://github.com/theforeman/foreman/blob/1.7.0-RC2/app/assets/stylesheets/charts.scss#L7
>
> Clearly it was meant to contain a bit more data at that point! I don't
> know what encoded SVG image these base64 strings are meant to represent,
> and would appreciate any ideas. Or perhaps somebody can forward this
> along to Amos, in case he remembers the intent.
>

reply from Amos:

My first guess is that the bullets are <ul> tags that are missing
list-style: none.
The base 64 are a way to embed images in the css, I think I used the
original css, from a package that used them.
It should be easy to replace the base64 with images from glyphicons if it
it doesn't work well anymore.
I don't have access to foreman UI at the moment, so I can't really test.
Amos.

··· On Thu, Nov 27, 2014 at 11:27 AM, Dominic Cleal wrote:

Cheers,

–
Dominic Cleal
Red Hat Engineering

–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

#3

>
>
>
> An issue that's been annoying me lately was bullet points appearing in
> production mode on the dashboard, next to the widgets on the grid.
>
> Bug #7487: Bullet points visible next to dashboard widgets - Foreman
>
> It seems that this was caused by some inadvertent UTF-8 in our charts
> and gridster.scss files, which wasn't declared with @charset.
>
> To help you find them, look at these lines, half way along:
> https://github.com/theforeman/foreman/blob/1.7.0-RC2/app/assets/stylesheets/gridster.scss#L173
> https://github.com/theforeman/foreman/blob/1.7.0-RC2/app/assets/stylesheets/charts.scss#L7
>
> Clearly it was meant to contain a bit more data at that point! I don't
> know what encoded SVG image these base64 strings are meant to represent,
> and would appreciate any ideas. Or perhaps somebody can forward this
> along to Amos, in case he remembers the intent.
>
>
> reply from Amos:
>
> My first guess is that the bullets are <ul> tags that are missing
> list-style: none.

Yeah, exactly. The ticket explains more, but a Unicode BOM was getting
into the precompiled and concatenated output CSS, which then prevented
the browser from parsing the style that disabled the bullet.

> The base 64 are a way to embed images in the css, I think I used the
> original css, from a package that used them.
> It should be easy to replace the base64 with images from glyphicons if
> it it doesn't work well anymore.

Thanks for checking with Amos. I think the original CSS was using the
SVG as a fallback for browsers that didn't support gradients, so I've
simply removed it. The gradient's so subtle anyway on my monitor that
the other fallback of a solid colour will do just fine, IMHO.

··· On 27/11/14 10:40, Ohad Levy wrote: > On Thu, Nov 27, 2014 at 11:27 AM, Dominic Cleal > wrote:

–
Dominic Cleal
Red Hat Engineering