BMC interface complains if more than one host has an empty Name field, is this necessary?

Development
1

I cannot add more than one host with an empty BMC Name field. I wouldn't
expect to be required to have a DNS entry for my IPMI interface. Is this
simply an oversight on the part of the nic/bmc.rb model?

Nic::BMC inherits from Nic::Managed. In Nic::Managed,

validates_uniqueness_of :name, :scope => :domain_id

I would suggest that in Nic::BMC, this is overridden with:

validates_uniqueness_of :name, :scope => :domain_id, :allow_nil =>

true, :allow_blank => true

Cheers,
Aaron

2

Update - This has been merged, thanks Foreman crew!
https://github.com/theforeman/foreman/pull/971

ยทยทยท On Monday, October 21, 2013 7:00:25 PM UTC-7, Aaron Stone wrote: > > I cannot add more than one host with an empty BMC Name field. I wouldn't > expect to be required to have a DNS entry for my IPMI interface. Is this > simply an oversight on the part of the nic/bmc.rb model? > > Nic::BMC inherits from Nic::Managed. In Nic::Managed, > > validates_uniqueness_of :name, :scope => :domain_id > > I would suggest that in Nic::BMC, this is overridden with: > > validates_uniqueness_of :name, :scope => :domain_id, :allow_nil => > true, :allow_blank => true > > Cheers, > Aaron >