ekohl
November 28, 2019, 11:24am
1
In my ongoing quest to drop the Ruby-based PRProcessor I’m starting the next bit:
theforeman:master
← ekohl:drop-path-labels
opened 11:04AM - 28 Nov 19 UTC
Depends on:
* https://github.com/theforeman/foreman/pull/7216
* https://github.c… om/theforeman/community-templates/pull/667
To replace the functionality I’ve opened two PRs:
theforeman:develop
← ekohl:28380-labeler
opened 11:00AM - 28 Nov 19 UTC
Previously we had our own implementation in our PRProcessor but this allows drop… ping that code in favor of a generic implementation.
theforeman:develop
← ekohl:labeler
opened 10:55AM - 28 Nov 19 UTC
Previously we had our own implementation in our PRProcessor but this allows drop… ping that code in favor of a generic implementation.
An example of how it looks like:
ekohl:labeler
← ekohl:test-labeler
opened 11:23AM - 28 Nov 19 UTC
Unless there are objections I’ll merge this next week
3 Likes
ekohl
November 29, 2019, 12:05pm
2
Since @mmoll merged the core PRs I’ve merged and deployed the PR processor update.
1 Like
ekohl
December 2, 2019, 9:50am
3
It looks like there’s a limitation I wasn’t aware of. Looks like the workflow doesn’t work on forks. Essentially this is always our workflow so that’s a blocker for us.
opened 08:15AM - 26 Aug 19 UTC
closed 05:32PM - 05 Feb 20 UTC
Hi there,
I've implemented the exact Labeler workflow as the [starter-workflo… w template](https://github.com/actions/starter-workflows/blob/master/automation/label.yml) in the dir path `.github/workflows/label.yml`.
I have also added the `.github/labeler.yml` file with the configuration below:
```
Trader: packages/trader/**/*
Bot: packages/bot/**/*
Core: packages/core/**/*
Components: packages/components/**/*
Shared: packages/shared/**/*
```
The action is recognised and runs on PR, however the Labeler action resolves with the following error:
```
##[error]HttpError: Resource not accessible by integration
##[error]Resource not accessible by integration
##[error]Node run failed with exit code 1
```
Googling seems to relate that error with invalid access to the repo by the action app, so I thought I'd create an issue and disable the action for now, but would be happy to know if there's something I have missed out that will be able to solve this issue for me.
Thanks.
I’m going to look at alternatives but perhaps we need to bring this back in our old bot in the mean time.
ekohl
December 2, 2019, 6:59pm
4
theforeman:develop
← ekohl:revert-labeler
opened 02:51PM - 02 Dec 19 UTC
This reverts commit ac1f16184601bb007d017b32d151783d84c29f22.
It turns out this… only works with PRs from the same repository. However,
our workflow is that PRs are always coming from another repository
rendering the labeler useless.
theforeman:develop
← ekohl:revert-labeler
opened 02:50PM - 02 Dec 19 UTC
This reverts commit e56a1b5151c795058e5af7c739e11ee043992abd.
It turns out this… only works with PRs from the same repository. However, our workflow is that PRs are always coming from another repository rendering the labeler useless.
Will revert the change in PR Processor as well.
1 Like