Please double check issue numbers in commit messages are correct as part
of the PR review and when merging, otherwise they can close the wrong
issue. Just had a couple of Foreman issues get closed because of
incorrect #s in Katello PRs.
What if we were to reference an existing Katello github issue, could it conflict with a redmine issue with the same number?
Thanks,
Walden
···
----- Original Message ----- From: "Dominic Cleal" To: foreman-dev@googlegroups.com Sent: Wednesday, January 8, 2014 6:54:39 AM Subject: [foreman-dev] Devs: please check redmine issue numbersPlease double check issue numbers in commit messages are correct as part
of the PR review and when merging, otherwise they can close the wrong
issue. Just had a couple of Foreman issues get closed because of
incorrect #s in Katello PRs.
–
Dominic Cleal
Red Hat Engineering
–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
I'm wondering if Katello should choose one or the other–either red mine or github issues–instead of trying to use both?
David
···
----- Original Message ----- > From: "Walden Raines" > To: foreman-dev@googlegroups.com > Sent: Wednesday, January 8, 2014 8:29:31 AM > Subject: Re: [foreman-dev] Devs: please check redmine issue numbers > > What if we were to reference an existing Katello github issue, could it > conflict with a redmine issue with the same number? > > Thanks, > Walden > > ----- Original Message ----- > From: "Dominic Cleal" > To: foreman-dev@googlegroups.com > Sent: Wednesday, January 8, 2014 6:54:39 AM > Subject: [foreman-dev] Devs: please check redmine issue numbers > > Please double check issue numbers in commit messages are correct as part > of the PR review and when merging, otherwise they can close the wrong > issue. Just had a couple of Foreman issues get closed because of > incorrect #s in Katello PRs. > > -- > Dominic Cleal > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/groups/opt_out. >Since foreman already uses redmine, and that is the new parent umbrella for katello, I vote for redmine. There is already a project there[1]; ping on #theforeman-dev irc to get your github login added to the project.
[1] Overview - Katello - Foreman