Disable foreman proxy TFTP support by default

ekohl · May 21, 2020, 4:54pm

Currently the installer enabled TFTP support by default, but I think this doesn’t make a huge amount of sense. Just TFTP doesn’t enable any feature. AFAIK you need DHCP for bare metal boot.

Am I missing anything or can we disable it by default?

On a technical level it’d flip true to false here:

github.com

theforeman/puppet-foreman_proxy/blob/c769fcaed71ef95f070371773c4b4208d3999427/manifests/params.pp#L229




# Logs settings
$logs           = true
$logs_listen_on = 'https'


# HTTPBoot settings - requires optional httpboot puppet module
$httpboot           = undef
$httpboot_listen_on = 'both'


# TFTP settings - requires optional TFTP puppet module
$tftp                   = true
$tftp_listen_on         = 'https'
$tftp_managed           = true
$tftp_manage_wget       = true
$tftp_dirs              = ["${tftp_root}/pxelinux.cfg","${tftp_root}/grub","${tftp_root}/grub2","${tftp_root}/boot","${tftp_root}/ztp.cfg","${tftp_root}/poap.cfg"]
$tftp_servername        = undef
$tftp_replace_grub2_cfg = false


# DHCP settings - requires optional DHCP puppet module
$dhcp                    = false
$dhcp_listen_on          = 'https'

Marek_Hulan · May 21, 2020, 5:48pm

+1 for disabling, I guess it was enabled since it’s easy to install and usually does not interfere with other services on the same network

lzap · May 22, 2020, 12:22pm

As long as the upgrade won’t disable TFTP for everyone, I am good.

ekohl · May 25, 2020, 3:47pm

This would be limited to new installations. Touching existing installations is something I avoid when possible.

apatelKmd · June 18, 2020, 1:26pm

We rely on the default true as out install requires DHCP+TFTP. Default False is not a deal breaker for us as long as an option override is supported.

ekohl · June 23, 2020, 10:35am

https://projects.theforeman.org/issues/30198

To be clear, this only affects defaults. That means only fresh installations when using the installer. Direct users of the Puppet module also need to modify their setup.

I’ll also go over the manual to see where we need to suggest --foreman-proxy-tftp true and write an upgrade warning.