Disabled host status icons not working in 1.10-RC1

Development
1

So in previous versions of Foreman, hosts that have been "disabled"
show a grey icon for their aggregated status in the host list.
Currently they are showing as "green". I also noted that out of sync
hosts that previously showed up with an orange icon, now also show up
as "green".

Related tickets:

Feature #12213: Support for preferring a particular host status in the global view - Foreman - Support for preferring a
particular host status in the global view - Foreman"
Bug #11704: Configuration no report appears as "green" icon - Foreman - Configuration no report appears
as "green" icon - Foreman
Feature #10782: Add global status for hosts - Foreman - Add global status for hosts - Foreman

When rendering the aggregated icon in the host list (and also when
incorporating into the dashboard piechart) we should follow this set
of precedence (unless we decide to change it for some reason).

  1. Notifications Disabled (Grey)
  2. Out Of Sync (Orange)
  3. Error (Red)
  4. Active / Pending (it shouldn't be possible to be in both states) (Blue?) [*]
  5. Good (Green)

See the following older ticket for some history on this.
http://projects.theforeman.org/issues/1617

Are we in agreement that the disabled host icon shouldn't be a green
check mark, and the above order of precedence for aggregated statuses
still makes the most sense?

Thanks,
Brian

    • Note that in certain stats, "Active" should be considered the same
      as "Good", but in others in can be a separate state.
2

> So in previous versions of Foreman, hosts that have been "disabled"
> show a grey icon for their aggregated status in the host list.
> Currently they are showing as "green".

I think this is expected in the global status (#10782) change. The
realisation I had when reviewing it was that information loss in status
icons on the host list is inevitable if I accepted it.

The alternatives were to introduce more global states, which only make
sense in certain contexts (undermining the idea of a single global state
with more detailed ones), or to show the detailed statuses too.

Currently detailed config management statuses are shown on, a) the
dashboard, b) tooltips on host list, c) properties table on a host#show
page.

> I also noted that out of sync
> hosts that previously showed up with an orange icon, now also show up
> as "green".

This doesn't sound right - the config status should show as a warning if
it's out of sync, and seems to work for me.

If you bring up a Rails console, you could try running:

Host.find_by_name('example.com').get_status(HostStatus::ConfigurationStatus).out_of_sync?

It should return false. If not, dig into
app/models/host_status/configuration_status.rb.

> Related tickets:
>
> Feature #12213: Support for preferring a particular host status in the global view - Foreman - Support for preferring a
> particular host status in the global view - Foreman"

I agree with the comment that Marek added to this ticket today, that
perhaps the host list should be customisable. This would probably fix
the issue described in the first part of this e-mail. Either that, or
find a way to concisely show the detailed statuses, but that probably
wouldn't be very readable or accessible.

> When rendering the aggregated icon in the host list (and also when
> incorporating into the dashboard piechart) we should follow this set
> of precedence (unless we decide to change it for some reason).
>
> 1) Notifications Disabled (Grey)
> 2) Out Of Sync (Orange)
> 3) Error (Red)
> 4) Active / Pending (it shouldn't be possible to be in both states) (Blue?) [*]
> 5) Good (Green)
>
> See the following older ticket for some history on this.
> Bug #1617: Dashboard piechart stats don't match expectations. - Foreman
>
> Are we in agreement that the disabled host icon shouldn't be a green
> check mark, and the above order of precedence for aggregated statuses
> still makes the most sense?

I don't think I agree about the global status having this precedence,
but I certainly agree that the configuration status of the host should
continue to show these states.

I think the behaviour we've lost is the coloured icon showing only the
configuration state. I think we still successfully kept the knowledge
of disabled, active, pending etc, it's just not being displayed in the
same way. If we can find a better way to display it as well as the
global state, then this would help.

··· On 19/10/15 17:09, Brian Gupta wrote:

–
Dominic Cleal
dominic@cleal.org