Error starting smart-proxy w/ remote execution

thomasmckay · December 11, 2015, 6:00pm

Dec 11 12:53:16 katello-katello systemd: Starting Foreman Proxy…
Dec 11 12:53:16 katello-katello smart-proxy: Performance on MRI may be improved
with the concurrent-ruby-ext gem. Please see http://concurrent-ruby.com
Dec 11 12:53:16 katello-katello smart-proxy: /usr/share/gems/gems/smart_proxy_r
emote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:3:in <mo\ dule:Ssh>': uninitialized constant Sinatra (NameError) Dec 11 12:53:16 katello-katello smart-proxy: from /usr/share/gems/gems/smart_pr\ oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:2:in\<module:RemoteExecution>'
Dec 11 12:53:16 katello-katello smart-proxy: from /usr/share/gems/gems/smart_pr
oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:1:in
`<top (required)>'

I am running foreman, katello, and foreman_remote_execution from git.

···

-- @thomasmckay

–
“The leader must aim high, see big, judge widely, thus setting himself apart form the ordinary people who debate in narrow confines.” ~ Charles De Gaulle

“Leadership is about making others better as a result of your presence and making sure that impact lasts in your absence.” ~ Harvard Business School

thomasmckay · December 11, 2015, 7:02pm

Work around in redmine

http://projects.theforeman.org/issues/12786

···

----- Original Message ----- > > Dec 11 12:53:16 katello-katello systemd: Starting Foreman Proxy... > Dec 11 12:53:16 katello-katello smart-proxy: Performance on MRI may be > improved\ > with the concurrent-ruby-ext gem. Please see http://concurrent-ruby.com > Dec 11 12:53:16 katello-katello smart-proxy: > /usr/share/gems/gems/smart_proxy_r\ > emote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:3:in > ` dule:Ssh>': uninitialized constant Sinatra (NameError) > Dec 11 12:53:16 katello-katello smart-proxy: from > /usr/share/gems/gems/smart_pr\ > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:2:in\ > `' > Dec 11 12:53:16 katello-katello smart-proxy: from > /usr/share/gems/gems/smart_pr\ > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:1:in\ > `' > > > I am running foreman, katello, and foreman_remote_execution from git. > > -- > @thomasmckay > > -- > "The leader must aim high, see big, judge widely, thus setting himself apart > form the ordinary people who debate in narrow confines." ~ Charles De Gaulle > > "Leadership is about making others better as a result of your presence and > making sure that impact lasts in your absence." ~ Harvard Business School > > -- > You received this message because you are subscribed to the Google Groups > "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an > email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout. >

stbenjam · December 11, 2015, 7:49pm

>
>
> >
> > Dec 11 12:53:16 katello-katello systemd: Starting Foreman Proxy…
> > Dec 11 12:53:16 katello-katello smart-proxy: Performance on MRI may be
> > improved
> > with the concurrent-ruby-ext gem. Please see http://concurrent-ruby.com
> > Dec 11 12:53:16 katello-katello smart-proxy:
> > /usr/share/gems/gems/smart_proxy_r
> > emote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:3:in
> > <mo\ > > dule:Ssh>': uninitialized constant Sinatra (NameError) > > Dec 11 12:53:16 katello-katello smart-proxy: from > > /usr/share/gems/gems/smart_pr\ > > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:2:in\ > ><module:RemoteExecution>'
> > Dec 11 12:53:16 katello-katello smart-proxy: from
> > /usr/share/gems/gems/smart_pr
> > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:1:in
> > `<top (required)>'
> >
> >
> > I am running foreman, katello, and foreman_remote_execution from git.
> >
> > –
> > @thomasmckay
> >
> > –
> > "The leader must aim high, see big, judge widely, thus setting himself apart
> > form the ordinary people who debate in narrow confines." ~ Charles De Gaulle
> >
> > "Leadership is about making others better as a result of your presence and
> > making sure that impact lasts in your absence." ~ Harvard Business School
> >
> > –
> > You received this message because you are subscribed to the Google Groups
> > "foreman-dev" group.
> > To unsubscribe from this group and stop receiving emails from it, send an
> > email to foreman-dev+unsubscribe@googlegroups.com.
> > For more options, visit https://groups.google.com/d/optout.
> >
>
>
> Work around in redmine
>
> Bug #12786: uninitialized constant Sinatra in smart_proxy_remote_execution_ssh - Foreman Remote Execution - Foreman

Thanks, I haven't seen the particular error myself, but it seems
inconsistent about whether plugin's api.rb include's the require
'sinatra' line. smart_proxy_salt does, but Rex and OpenSCAP don't.

Also,

github.com

theforeman/smart_proxy_example/blob/master/lib/smart_proxy_example/example_api.rb

require 'sinatra'
require 'smart_proxy_example/example'
require 'smart_proxy_example/example_main'

module Proxy::Example

  class Api < ::Sinatra::Base
    include ::Proxy::Log
    helpers ::Proxy::Helpers

    get '/hello' do
      Proxy::Example.say_hello
    end
  end
end

includes it.

···

On Fri, Dec 11, 2015 at 02:02:23PM -0500, Tom McKay wrote: > ----- Original Message -----

–
You received this message because you are subscribed to the Google Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

–
Best Regards,

Stephen Benjamin
Red Hat Engineering

Dmitri_Dolguikh · December 11, 2015, 8:14pm

Shouldn’t need to require sinatra, as it is smart-proxy’s dependency
(https://github.com/theforeman/smart-proxy/blob/develop/smart_proxy.gemspec#L18).
Looking at smart_proxy_remote_execution_ssh I see that it requires all
its dependencies in smart_proxy_remote_execution_ssh.rb, which may
(and does) result in it attempting to reference Sinatra::Base before
it is available.

I would suggest moving all but
"smart_proxy_remote_execution_ssh/plugin” requires into Plugin class'
after_activation block.

Cheers,
-d

···

On Fri, Dec 11, 2015 at 8:49 PM, Stephen Benjamin wrote: > On Fri, Dec 11, 2015 at 02:02:23PM -0500, Tom McKay wrote: >> >> >> ----- Original Message ----- >> > >> > Dec 11 12:53:16 katello-katello systemd: Starting Foreman Proxy... >> > Dec 11 12:53:16 katello-katello smart-proxy: Performance on MRI may be >> > improved\ >> > with the concurrent-ruby-ext gem. Please see http://concurrent-ruby.com >> > Dec 11 12:53:16 katello-katello smart-proxy: >> > /usr/share/gems/gems/smart_proxy_r\ >> > emote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:3:in >> > `> > dule:Ssh>': uninitialized constant Sinatra (NameError) >> > Dec 11 12:53:16 katello-katello smart-proxy: from >> > /usr/share/gems/gems/smart_pr\ >> > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:2:in\ >> > `' >> > Dec 11 12:53:16 katello-katello smart-proxy: from >> > /usr/share/gems/gems/smart_pr\ >> > oxy_remote_execution_ssh-0.0.8/lib/smart_proxy_remote_execution_ssh/api.rb:1:in\ >> > `' >> > >> > >> > I am running foreman, katello, and foreman_remote_execution from git. >> > >> > -- >> > @thomasmckay >> > >> > -- >> > "The leader must aim high, see big, judge widely, thus setting himself apart >> > form the ordinary people who debate in narrow confines." ~ Charles De Gaulle >> > >> > "Leadership is about making others better as a result of your presence and >> > making sure that impact lasts in your absence." ~ Harvard Business School >> > >> > -- >> > You received this message because you are subscribed to the Google Groups >> > "foreman-dev" group. >> > To unsubscribe from this group and stop receiving emails from it, send an >> > email to foreman-dev+unsubscribe@googlegroups.com. >> > For more options, visit https://groups.google.com/d/optout. >> > >> >> >> Work around in redmine >> >> http://projects.theforeman.org/issues/12786 > > Thanks, I haven't seen the particular error myself, but it seems > inconsistent about whether plugin's api.rb include's the require > 'sinatra' line. smart_proxy_salt does, but Rex and OpenSCAP don't. > > Also, > https://github.com/theforeman/smart_proxy_example/blob/master/lib/smart_proxy_example/example_api.rb > includes it. > > >> >> -- >> You received this message because you are subscribed to the Google Groups "foreman-dev" group. >> To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com. >> For more options, visit https://groups.google.com/d/optout. > > -- > Best Regards, > > Stephen Benjamin > Red Hat Engineering > > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.