Foreman 1.4.1 clone bug/fix

Development
1

Hi,

I have come across a bug introduced in 1.4.1 which I think is related to
using short hostnames in vmware and trying to clone a machine.

the fix is to alter line 158 in
"/usr/share/foreman/app/models/host/managed.rb"

  • name.include?('.') ? name : "#{name}.#{domain}"
  • (name || '').include?('.') ? name : "#{name}.#{domain}"

this code was added in the 1.4.1 release as a fix for this issue:

http://projects.theforeman.org/issues/4234

Hope this is helpful,

Thanks,

-James

2

Hi James,

I'm not sure I understand what problem you're hitting, but I'd suggest
filing this as a redmine issue with as much debug as you can get -
especially if you're getting an error and/or stacktrace in the logs.

You can also submit a pull request for the code change, following the
steps here: Foreman :: Contribute

(Though without understanding the problem first, I'd be hesitant to
commit the patch.)

Thanks!

··· On 26/02/14 15:58, James Jenkins wrote: > Hi, > > I have come across a bug introduced in 1.4.1 which I think is related to > using short hostnames in vmware and trying to clone a machine. > > the fix is to alter line 158 in > "/usr/share/foreman/app/models/host/managed.rb" > > - name.include?('.') ? name : "#{name}.#{domain}" > + (name || '').include?('.') ? name : "#{name}.#{domain}" > > this code was added in the 1.4.1 release as a fix for this issue: > > http://projects.theforeman.org/issues/4234 > > Hope this is helpful,

–
Dominic Cleal
Red Hat Engineering

3

http://projects.theforeman.org/issues/4485

pull request created

Thanks.

··· On Wednesday, 26 February 2014 15:58:50 UTC, James Jenkins wrote: > > Hi, > > I have come across a bug introduced in 1.4.1 which I think is related to > using short hostnames in vmware and trying to clone a machine. > > the fix is to alter line 158 in > "/usr/share/foreman/app/models/host/managed.rb" > > - name.include?('.') ? name : "#{name}.#{domain}" > + (name || '').include?('.') ? name : "#{name}.#{domain}" > > this code was added in the 1.4.1 release as a fix for this issue: > > http://projects.theforeman.org/issues/4234 > > Hope this is helpful, > > Thanks, > > -James >