Foreman-ansible-modules does not support the BMC type of Redfish

Problem: While looking at the foreman-ansible-modules repo (2021-05-03) code, I noticed that it does not mention Redfish as a supported and documented BMC type.

Please note: I’m not a foreman developer and don’t have the knowledge of how to setup a foreman developer environment to test this trivial change (see the code below). This is a “If you see something, you should say something” post, so that someone who has BMCs (my home lab does not), does not have to wait for a release cycle when they actually need this support.

Expected outcome: Redfish BMC are supported and documented like as they are in hammer for v2.4.0

Foreman and Proxy versions: Irrelevant (Found in source code in git repo - 2021-05-03)

Foreman and Proxy plugin versions: Irrelevant (Found in source code in git repo - 2021-05-03)

Distribution and version: Irrelevant (Found in source code in git repo - 2021-05-03)

Other relevant data:

plugins/module_utils/foreman_helper.py
1835-    username=dict(),
1836-    password=dict(no_log=True),
1837:    provider=dict(choices=['IPMI', 'SSH']),
1838-    virtual=dict(type='bool'),
1839-    tag=dict(),

plugins/modules/host.py
200-      provider:
201-        description:
202:          - Interface provider, e.g. IPMI.
203-          - Only for BMC interfaces.
204-        type: str
205-        choices:
206:          - 'IPMI'
207-          - 'SSH'
208-      virtual:
2 Likes

Hi!

Thanks for noticing that!

I’ve opened a PR to add Redfish to the list of possible BMCs:

1 Like