Foreman core nightly is currently broken

Development
1

Hi,

Following up on the recent thread about merging PR's, just to let you know
that develop branch is currently broken due to [1] and PR to fix it as
already available at [2] and hopefully it will be back to usual business
within the next few hours.

Please don't merge any JS related commits until the issue is resolved.

thanks,
Ohad

[1] https://github.com/theforeman/foreman/pull/4792
[2] https://github.com/theforeman/foreman/pull/4809

2

There is now another approach to fix this by using a plain Object instead
of a Map[1].
This won't require any additional dependencies to be added.

[1] https://github.com/theforeman/foreman/pull/4811

··· On Tuesday, September 5, 2017 at 9:27:13 AM UTC+2, ohadlevy wrote: > > Hi, > > Following up on the recent thread about merging PR's, just to let you know > that develop branch is currently broken due to [1] and PR to fix it as > already available at [2] and hopefully it will be back to usual business > within the next few hours. > > Please don't merge any JS related commits until the issue is resolved. > > thanks, > Ohad > > [1] https://github.com/theforeman/foreman/pull/4792 > [2] https://github.com/theforeman/foreman/pull/4809 >
3

This commit has been reverted from 1.15-stable and 1.16-stable

··· On 09/05, Ohad Levy wrote: > Hi, > > Following up on the recent thread about merging PR's, just to let you know > that develop branch is currently broken due to [1] and PR to fix it as > already available at [2] and hopefully it will be back to usual business > within the next few hours. > > Please don't merge any JS related commits until the issue is resolved. > > thanks, > Ohad > > [1] https://github.com/theforeman/foreman/pull/4792 > [2] https://github.com/theforeman/foreman/pull/4809 > > -- > You received this message because you are subscribed to the Google Groups "foreman-dev" group. > To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com. > For more options, visit https://groups.google.com/d/optout.

–
Daniel Lobato Garcia

@dLobatog
blog.daniellobato.me
daniellobato.me

GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato

4

> There is now another approach to fix this by using a plain Object instead
> of a Map[1].
> This won't require any additional dependencies to be added.
>
> [1] Refs #19554 - Rewrite to use an Object and not Map by bastilian · Pull Request #4811 · theforeman/foreman · GitHub
>

Thanks Sebastian for the fix, this is now resolved.

··· On Tue, Sep 5, 2017 at 12:36 PM, Sebastian Gräßl wrote:

On Tuesday, September 5, 2017 at 9:27:13 AM UTC+2, ohadlevy wrote:

Hi,

Following up on the recent thread about merging PR’s, just to let you
know that develop branch is currently broken due to [1] and PR to fix it as
already available at [2] and hopefully it will be back to usual business
within the next few hours.

Please don’t merge any JS related commits until the issue is resolved.

thanks,
Ohad

[1] Fixes #19554 - Provide warning for unsupported PXE loader combinations by tstrachota · Pull Request #4792 · theforeman/foreman · GitHub
[2] Fixes #20846 - Include babel-polyfill to support ES6 Map by bastilian · Pull Request #4809 · theforeman/foreman · GitHub

–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.