foreman-develop-package-release 928 failed

foreman package release pipeline failed:

ModuleNotFoundError: Module not found: Error: Can't resolve '@patternfly/react-icons/dist/js/icons/exclamation-circle-icon' in '/builddir/build/BUILD/foreman-2.5.0-develop/webpack/assets/javascripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/components'

introduced here:

ModuleNotFoundError: Module not found: Error: Can’t resolve ‘@patternfly/react-icons/dist/js/icons/exclamation-circle-icon’ in ‘/builddir/build/BUILD/foreman-2.5.0-develop/webpack/assets/javascripts/react_app/routes/RegistrationCommands/RegistrationCommandsPage/components’

maybe import { ExclamationCircleIcon } from '@patternfly/react-icons'; will fix it?

I remember we had a very similar issue with pf/react-icons before, but can’t remember what the fix was.

Might be worth searching history here and in git.

this one is a freshly new component, though if it happens a lot, we could explore adding a lint rule for it as @tbrisker suggested on the PR

And now that I searched for it, the old fix was similar:

So let’s try your suggestion

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.