foreman-installer-develop-package-release 1035 failed

jenkins · January 18, 2022, 3:16am

foreman-installer package release pipeline failed:

https://ci.theforeman.org/job/foreman-installer-develop-package-release/1035/

ekohl · January 18, 2022, 10:58am

Looks like we’ll need to teach Kafo about the Sensitive data type because merging this PR broke it:

ekohl · January 20, 2022, 12:01pm

I came up with patches that I’m going to test now:

github.com/theforeman/kafo

Implement Sensitive data type support

theforeman:master ← ekohl:sensitive

opened 11:20AM - 20 Jan 22 UTC

ekohl

+154 -60

The Sensitive data type is implemented by copying Variant. While this isn't pret…ty (duplication is never great), it gets the job done. One of the biggest changes is that in order to use Sensitive an entry in Hiera to convert must exist. This should be implemented in modules using data in modules but it can be implemented in the installer's Hiera config as well. This is based on [Puppet's documentation](https://puppet.com/docs/puppet/6/securing-sensitive-data.html)

github.com/theforeman/puppet-foreman

Pass potentially Sensitive params as Sensitive

theforeman:master ← ekohl:sensitive-v2

opened 12:00PM - 20 Jan 22 UTC

ekohl

+42 -12

In 699f944c93b8cf3718b16e6b9de7143c1e55bbe8 the parameters started to accept Sen…sitive but it didn't default to Sensitive. They also weren't converting data coming from Hiera. This adds a data-in-modules setup and sets lookup_options for those. This means Kafo (which heavily relies on Hiera) will pass sensitive values. Currently a draft so I can verify it end to end with the installer.

system · January 27, 2022, 12:02pm

This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.