Foreman-installer enables puppet.service although puppet integration is not enabled

gvde · April 25, 2022, 7:48am

Problem:

I have just ran a foreman-installer on a new AlmaLinux 8 installing Katello 4.4. I have noticed at the end of the installation puppet.service is enabled and running although puppet integration has not been enabled.

Running foreman-installer like this for the very first time on this server:

[root@foreman8 ~]# foreman-installer --scenario katello \
   --foreman-initial-organization "ORG" --foreman-initial-location "Default" \
   --certs-server-ca-cert /etc/pki/tls/certs/bundle.crt \
   --certs-server-cert /etc/pki/tls/certs/foreman8.crt \
   --certs-server-key /etc/pki/tls/private/foreman8.key \
   --enable-foreman-plugin-remote-execution \
   --enable-foreman-proxy-plugin-remote-execution-ssh \
   --foreman-plugin-tasks-automatic-cleanup=true \
   --foreman-proxy-httpboot true \
   --foreman-proxy-tftp true

Expected outcome:

Don’t start puppet.service unless it’s set to be used.

Foreman and Proxy versions:
Foreman 3.2, Katello 4.4

Distribution and version:
AlmaLinux 8.5

Other relevant data:
katello.log shows it enables it:

2022-04-25 09:30:45 [DEBUG ] [configure] /Service[puppet]: Starting to evaluate the resource (1802 of 1824)
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl is-active -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl is-enabled -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl show --property=NeedDaemonReload -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl unmask -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl start -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl is-enabled -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl unmask -- puppet'
2022-04-25 09:30:45 [DEBUG ] [configure] Executing: '/bin/systemctl enable -- puppet'
2022-04-25 09:30:45 [INFO  ] [configure] /Stage[main]/Puppet::Agent::Service::Daemon/Service[puppet]/ensure: ensure changed 'stopped' to 'running'
2022-04-25 09:30:45 [DEBUG ] [configure] /Service[puppet]: The container Class[Puppet::Agent::Service::Daemon] will propagate my refresh event
2022-04-25 09:30:45 [DEBUG ] [configure] /Service[puppet]: Unscheduling refresh on Service[puppet]
2022-04-25 09:30:45 [DEBUG ] [configure] /Service[puppet]: Evaluated in 0.59 seconds

gvde · April 25, 2022, 8:51am

O.K. The problem is also mentioned in Connection to foreman:8140/puppet-ca/v1 failed

@ezr-ondrej is there already a redmine/github issue to track this?

ezr-ondrej · April 25, 2022, 7:20pm

No, I did not, this is something for @packaging team
Should we track this somehow?

evgeni · April 26, 2022, 6:55am

Given we don’t package or ship Puppet, no, this is not for at-packaging.

It might be for at-installer tho

evgeni · April 26, 2022, 7:59am

The issue is here:

github.com

theforeman/puppet-foreman_proxy_content/blob/413896789684ca48012a78e63ca014fd73e5d26c/manifests/init.pp#L98

    
      
          # $pulpcore_django_secret_key::                Secret key used for cryptographic operations by Pulpcore's django runtime
          #
          # $pulpcore_cache_enabled::                    Enable Redis based content caching within the Pulp content app.
          #
          # $pulpcore_cache_expires_ttl::                The number of seconds that content should be cached for.
          #                                              Specify 'None' to never expire the cache.
          #
          class foreman_proxy_content (
            Boolean $pulpcore_mirror = false,
          
          
  Boolean $puppet = true,
          
          
  Boolean $reverse_proxy = false,
            Stdlib::Port $reverse_proxy_port = 8443,
          
          
  Optional[String] $qpid_router_hub_addr = undef,
            Stdlib::Port $qpid_router_hub_port = 5646,
            Optional[String] $qpid_router_agent_addr = undef,
            Stdlib::Port $qpid_router_agent_port = 5647,
            String $qpid_router_broker_addr = 'localhost',
            Stdlib::Port $qpid_router_broker_port = 5671,

And I can repro this on a fresh Katello 4.4, but not on a Satellite build I have here. Need to investigate the differences.

I’ve opened Bug #34819: Puppet Agent enabled in Katello installations, even if it should not - Installer - Foreman to track this.

evgeni · April 26, 2022, 8:55am

Mkay, the difference is that for Katello, we deploy a default answers file with:

foreman_proxy_content: true

While in Satellite we have:

foreman_proxy_content:
  puppet: false

I still think the puppet module should just default to off…