Foreman RPM nightly pipeline failed:
I merged quite some packaging bumps yesterday, so it’s maybe that. Looking.
NameError: uninitialized constant Uglifier
I think the problem is that the
uglifier gem is not loaded when
config.rb is parsed, and in the past using
:uglifier would trigger sprockets or something, but now it doesn’t?
Or it is because
uglifier is in the
assets group, but that is not installed on production installs.
Maybe we need to update Uglifier version:
if we’re using Uglifier, we’re using the latest version: 4.2, but in production installs it’s not there as we do not install the
asserts group in RPM installs.
oh, missed that
so how should we proceed with this? are we able to install those assets in production?
do we want to revert this change for now?
I would prefer not to require any assets related gems in production, no.
We could also do something ugly (lol) like
if defined?(Uglifier) config.assets.js_compressor = Uglifier.new(harmony: true) else config.assets.js_compressor = :uglifier end
(but I’d prefer not to?)
Well, the easiest solution would be to revert it, especially since this change is not really necessary.
For those who keep notes: this was reverted in Revert "Fixes #35890 - enable harmony mode with Uglifier to use ES6 syntax" by Ron-Lavi · Pull Request #9594 · theforeman/foreman · GitHub
And foreman-nightly-rpm-pipeline [Jenkins] is green!
This topic was automatically closed 7 days after the last reply. New replies are no longer allowed.