Hammer sync-plan create date mismatch

WScottB · August 17, 2021, 4:44pm

Problem:
hammer sync-plan create using --sync-date doesn’t provide desired result

[root@HOSTNAME rpm-gpg]# hammer sync-plan create \

–interval weekly
–description “Saturdays at 1AM”
–enabled true
–name “Saturday 1AM”
–sync-date “2021-08-21 01:00:00”
Sync plan created.
[root@HOSTNAME rpm-gpg]# hammer sync-plan list
—|--------------|---------------------|----------|---------|-----------------|-------------------
ID | NAME | START DATE | INTERVAL | ENABLED | CRON EXPRESSION | RECURRING LOGIC ID
—|--------------|---------------------|----------|---------|-----------------|-------------------
2 | Saturday 1AM | 2021/08/20 18:00:00 | weekly | yes | | 2
—|--------------|---------------------|----------|---------|-----------------|-------------------

Expected outcome:
Expected start date to be 2021/08/21 01:00:00, per the --sync-date value.

Foreman and Proxy versions:
foreman-3.0.0-0.1.rc1
katello-4.2.0.rc1-1

Foreman and Proxy plugin versions:

Distribution and version:
CentOS Linux release 7.9.2009

Other relevant data:

WScottB · August 17, 2021, 4:48pm

I suppose that I could just use cron notation. Just wanted to get this noted.

cintrix84 · August 17, 2021, 5:46pm

Hi @WScottB

It looks like it takes a string as the param:

github.com

Katello/katello/blob/master/app/controllers/katello/api/v2/sync_plans_controller.rb#L15

    
      
          include Katello::Concerns::FilteredAutoCompleteSearch
          before_action :find_organization, :only => [:create, :index, :auto_complete_search]
          before_action :find_authorized_katello_resource, :only => [:update, :show, :destroy, :sync,
                                                                     :add_products, :remove_products]
          before_action :set_organization, :only => [:update, :show, :destroy, :sync,
                                                     :add_products, :remove_products]
          
          
def_param_group :sync_plan do
            param :name, String, :desc => N_("sync plan name"), :required => true, :action_aware => true
            param :interval, SyncPlan::TYPES, :desc => N_("how often synchronization should run"), :required => true, :action_aware => true
            param :sync_date, String, :desc => N_("start datetime of synchronization"), :required => true, :action_aware => true
            param :description, String, :desc => N_("sync plan description")
            param :enabled, :bool, :desc => N_("enables or disables synchronization"), :required => true, :action_aware => true
            param :cron_expression, String, :desc => N_("Add custom cron logic for sync plan")
          end
          
          
api :GET, "/sync_plans", N_("List sync plans")
          api :GET, "/organizations/:organization_id/sync_plans"
          param :organization_id, :number, :desc => N_("Organization ID"), :required => true
          param :name, String, :desc => N_("filter by name")
          param :sync_date, String, :desc => N_("filter by sync date")

If you set it in the UI, does it list correctly with hammer?

WScottB · August 17, 2021, 5:57pm

It works correctly in the UI. Through a bit of trial and error, it seems that the code assumes UTC regardless of the system timezone? If I add the offset (-7 hours for AZ/MST), it works. This does conform to ISO 8601, but is confusing if you don’t happen to know that detail (as I did not). Maybe call that out explicitly in the documentation/help? I should be able to move on having figured that out.
[root@HOSTNAME rpm-gpg]# hammer sync-plan create \

–interval weekly
–description “Saturdays at 1AM”
–enabled true
–name “Saturday 1AM”
–sync-date “2021-08-21 01:00:00-7”
Sync plan created.
[root@HOSTNAME rpm-gpg]# hammer sync-plan list
—|--------------|---------------------|----------|---------|-----------------|-------------------
ID | NAME | START DATE | INTERVAL | ENABLED | CRON EXPRESSION | RECURRING LOGIC ID
—|--------------|---------------------|----------|---------|-----------------|-------------------
4 | Saturday 1AM | 2021/08/21 01:00:00 | weekly | yes | | 4
—|--------------|---------------------|----------|---------|-----------------|-------------------