Hammer version was changed to 2.0.0 -> please change the gemspec for hammer plugins

shiramax · February 10, 2020, 11:55am

Hi all,
We are changing the hammer version to 2.0.0 to be sync with foreman versions.
please check all the hammer plugins and make sure that any dependency on hammer_cli_foreman or hammer_cli is updated to allow this version.

GOOD:

gem.add_dependency 'hammer_cli_foreman'
gem.add_dependency 'hammer_cli_foreman', '>=0.17.0'

BAD:

gem.add_dependency 'hammer_cli_foreman', '>= 0.1.3', '< 1.0.0'
gem.add_dependency 'hammer_cli_foreman', '~> 0.17.3'

ekohl · February 12, 2020, 12:43pm

Looks like some plugins need an update:

github.com

theforeman/hammer_cli_foreman_openscap/blob/68e2c7e302e2370c1064f317c7ec19155e882a0b/hammer_cli_foreman_openscap.gemspec#L16


  s.name = "hammer_cli_foreman_openscap"
  s.authors = ["The Foreman team"]
  s.version = HammerCLIForemanOpenscap.version.dup
  s.platform = Gem::Platform::RUBY
  s.summary = %q{Foreman OpenSCAP commands for Hammer}
  s.license = "GPL-3"
  s.files = Dir['{lib,config,locale}/**/*', 'LICENSE', 'README.md']
  s.require_paths = ["lib"]
  s.test_files = Dir["test/**/*"]


  s.add_dependency 'hammer_cli_foreman', '~> 0.6'
end

github.com

theforeman/hammer-cli-foreman-tasks/blob/426f893b3a4b99e2dd0b30a2ed40a3e61124586a/hammer_cli_foreman_tasks.gemspec#L24


  s.homepage    = "https://github.com/theforeman/hammer-cli-foreman-tasks"
  s.summary     = "Foreman CLI plugin for showing tasks information for resoruces and users"
  s.description = <<DESC
Contains the code for showing of the tasks (results and progress) in the Hammer CLI.
DESC


  s.files = Dir["{lib,config,locale}/**/*", "LICENSE", "README.md"]
  s.require_paths = ["lib"]


  s.add_dependency "powerbar", ">= 1.0.11", "< 3.0"
  s.add_dependency "hammer_cli_foreman", "> 0.1.1", "< 1.0.0"
end

github.com

theforeman/hammer_cli_foreman_remote_execution/blob/86fb2e3924d432252e5f8950f26751f17a2f53f9/hammer_cli_foreman_remote_execution.gemspec#L19


  s.homepage      = 'https://github.com/theforeman/hammer_cli_foreman_remote_execution'
  s.license       = 'GPL-3.0-or-later'


  s.summary       = 'CLI for the Foreman remote execution plugin'
  s.description   = 'CLI for the Foreman remote execution plugin'


  s.files =            `git ls-files`.split("\n")
  s.test_files =       `git ls-files test`.split("\n")
  s.extra_rdoc_files = `git ls-files doc`.split("\n") + Dir['README*', 'LICENSE']


  s.add_dependency 'hammer_cli_foreman', '>= 0.1.3', '< 1.0.0'
  s.add_dependency 'hammer_cli_foreman_tasks', '~> 0.0.3'
end

@Ondrej_Prazak mind having a look?