How should changes to templates be handled going forward?
Provisioning templates, partition tables and report templates will all live in Foreman core repository, under app/views/unattended folder. PRs can be submitted normally to develop branch as well as to stable branches when needed for backports. Note that from now we will require redmine issues for all changes, as this will allow us to better control what template changes have been released in each version of Foreman. If the template change leads to change in the snapshot, rake snapshots:generate RAILS_ENV=test can be used to update the snapshot accordingly.
Remote execution job templates will reside in either the Remote Execution plugin for generic ssh templates, or in another plugin that adds them. For example, templates for the Ansible REX provider will reside in the Ansible plugin, while templates for Katello actions will reside in the Katello plugin.
In general, yes.
You don’t usually need to run all of the tests, but if snapshots change you will need to update the snapshot accordingly.
Also, you will need to make sure that every change has a redmine issue related to it. In the past we’ve had issues where changes in the community templates which did not have an issue led to problems and it was difficult to identify when the change was made, or when we wanted to pull some fix to an older release but had trouble with identifying which change was needed or only realized it at a very late stage in the release cycle.
This way nightly builds will also contain the latest templates so they can be tested right away and not only when a new release is done.
Note: The v2.4 manual Section 4.4.3 still references the community templates repository, in the last sentence of paragraph two - This sentence should be removed or updated to reflect the archiving of that repo.
I don’t mind doing the work, but what should I say? Looking at your original message and github, it would seem to be that the entirety of your post would be required starting at “How should changes …”. So should the page’s text be changed to reference this post in the development forum?
I this correct, or have I missed something? Should I copy out the entire relevant text from your post, which seems to me, to be excessive details for the target page! Did that text come from a development page that would be a better long term reference?
I hope you can see why I didn’t just jump in with a suggested change, because I didn’t and don’t know the answer to the questions raised which would provide a valuable revision, worth the time of those that would have to review it.
Thanks @illumino, I would suggest to modify the link to point to the relevant place on the foreman repo (app/views/unattended) and drop the part about it being synced, and maybe add a pointer to the contributing guidelines.