I am working on a small patch for fact importer - when there are too many keys in fact hash, Foreman would drop the whole data structure this to save resources: Feature #26984: Add a hard limit of 100 items to restrict any fact child-hash/array - Foreman
Now, it would be nice to give users ability to configure this value, which I am gonna propose to 100 by default. However we don’t want to add another setting.
I am wondering if we should create a file somewhere in
/usr/share/foreman/config/constants.rb which would load
/usr/share/foreman/config/constants.local.rb treated as ghost file (not overwritten during upgrade). Users would be able to fine-tune some of our internals. Documentation would be only in the
constants.rb file, so good candidates for such values would be things we do not want to expose and let users play around however we want have the ability to tell them to fine tune some values in very special cases (biggest customers, special deployments, containers etc).
What you think?