I find myself copying/pasting issue numbers from GitHub PRs to a redmine
url way too much every day. It takes a bit of time, and it's annoying as
well as easy to fix.
I've submitted this PR to comment on a newly submitted PR with links to the
associated issues in redmine: https://github.com/theforeman/prprocessor/pull/59 I'd like to hear your
thoughts if you have something to say about it.
Andrew
···
--
Andrew Kofink
akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch
···
On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink wrote:
I find myself copying/pasting issue numbers from GitHub PRs to a redmine
url way too much every day. It takes a bit of time, and it’s annoying as
well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with links to
the associated issues in redmine: https://github.com/
theforeman/prprocessor/pull/59 I’d like to hear your thoughts if you have
something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
I find myself copying/pasting issue numbers from GitHub PRs to a redmine
url way too much every day. It takes a bit of time, and it’s annoying as
well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with links to
the associated issues in redmine: https://github.com/th
eforeman/prprocessor/pull/59 I’d like to hear your thoughts if you have
something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
I find myself copying/pasting issue numbers from GitHub PRs to a redmine
url way too much every day. It takes a bit of time, and it’s annoying as
well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with links to
the associated issues in redmine: https://github.com/th
eforeman/prprocessor/pull/59 I’d like to hear your thoughts if you have
something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
I do it manually although I probably should just write a commit hook to do
it.
I put it in the message itself because I think it's useful to have there in
case anyone is browsing the git log or in case we ever move away from
github.
Walden
···
On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink wrote:
Walden, you have a script that adds it, or do you do it manually for every
issue? If the latter, then wouldn’t this save you some time?
John Mitsch
Red Hat Engineering
(860)-967-7285 <(860)%20967-7285>
irc: jomitsch
On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink akofink@redhat.com >>> wrote:
I find myself copying/pasting issue numbers from GitHub PRs to a
redmine url way too much every day. It takes a bit of time, and it’s
annoying as well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with links to
the associated issues in redmine: https://github.com/th
eforeman/prprocessor/pull/59 I’d like to hear your thoughts if you
have something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
> I do it manually although I probably should just write a commit hook to do
> it.
>
> I put it in the message itself because I think it's useful to have there in
> case anyone is browsing the git log or in case we ever move away from
> github.
Interesting idea. Before it gets in (+ idea for other places outside of
prprocessor scope), I'm using Tomas's grease monkey script and has been
very helpful in past
– Ivan
···
>
> Walden
>
> On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink wrote:
>
>> Walden, you have a script that adds it, or do you do it manually for every
>> issue? If the latter, then wouldn't this save you some time? ;)
>>
>> On Thu, Apr 6, 2017 at 5:24 PM, Walden Raines wrote:
>>
>>> I like it although I include the links to the issues in my actual commit
>>> message so it will be doubled up in my case.
>>>
>>>
>>>
>>> On Thu, Apr 6, 2017 at 4:18 PM, John Mitsch wrote:
>>>
>>>> +1 from me :)
>>>>
>>>> John Mitsch
>>>> Red Hat Engineering
>>>> (860)-967-7285 <(860)%20967-7285>
>>>> irc: jomitsch
>>>>
>>>> On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink >>>> wrote:
>>>>
>>>>> I find myself copying/pasting issue numbers from GitHub PRs to a
>>>>> redmine url way too much every day. It takes a bit of time, and it's
>>>>> annoying as well as easy to fix.
>>>>>
>>>>> I've submitted this PR to comment on a newly submitted PR with links to
>>>>> the associated issues in redmine: https://github.com/th
>>>>> eforeman/prprocessor/pull/59 I'd like to hear your thoughts if you
>>>>> have something to say about it.
>>>>>
>>>>> - Andrew
>>>>>
>>>>> --
>>>>> Andrew Kofink
>>>>> akofink@redhat.com
>>>>> IRC: akofink
>>>>> Associate Software Engineer
>>>>> Red Hat Satellite
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "foreman-dev" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to foreman-dev+unsubscribe@googlegroups.com.
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google
>>>> Groups "foreman-dev" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>> an email to foreman-dev+unsubscribe@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to foreman-dev+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>>
>>
>> --
>> Andrew Kofink
>> akofink@redhat.com
>> IRC: akofink
>> Associate Software Engineer
>> Red Hat Satellite
>>
>> --
>> You received this message because you are subscribed to the Google Groups
>> "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to foreman-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
>>
>
> --
> You received this message because you are subscribed to the Google Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
> Walden Raines <wraines@redhat.com> writes:
>
>> I do it manually although I probably should just write a commit hook to do
>> it.
>>
>> I put it in the message itself because I think it's useful to have there in
>> case anyone is browsing the git log or in case we ever move away from
>> github.
>
> Interesting idea. Before it gets in (+ idea for other places outside of
> prprocessor scope), I'm using Tomas's grease monkey script and has been
> very helpful in past
Forgot to put a link:
– Ivan
···
>
> -- Ivan
>
>>
>> Walden
>>
>> On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink wrote:
>>
>>> Walden, you have a script that adds it, or do you do it manually for every
>>> issue? If the latter, then wouldn't this save you some time? ;)
>>>
>>> On Thu, Apr 6, 2017 at 5:24 PM, Walden Raines wrote:
>>>
>>>> I like it although I include the links to the issues in my actual commit
>>>> message so it will be doubled up in my case.
>>>>
>>>>
>>>>
>>>> On Thu, Apr 6, 2017 at 4:18 PM, John Mitsch wrote:
>>>>
>>>>> +1 from me :)
>>>>>
>>>>> John Mitsch
>>>>> Red Hat Engineering
>>>>> (860)-967-7285 <(860)%20967-7285>
>>>>> irc: jomitsch
>>>>>
>>>>> On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink >>>>> wrote:
>>>>>
>>>>>> I find myself copying/pasting issue numbers from GitHub PRs to a
>>>>>> redmine url way too much every day. It takes a bit of time, and it's
>>>>>> annoying as well as easy to fix.
>>>>>>
>>>>>> I've submitted this PR to comment on a newly submitted PR with links to
>>>>>> the associated issues in redmine: https://github.com/th
>>>>>> eforeman/prprocessor/pull/59 I'd like to hear your thoughts if you
>>>>>> have something to say about it.
>>>>>>
>>>>>> - Andrew
>>>>>>
>>>>>> --
>>>>>> Andrew Kofink
>>>>>> akofink@redhat.com
>>>>>> IRC: akofink
>>>>>> Associate Software Engineer
>>>>>> Red Hat Satellite
>>>>>>
>>>>>> --
>>>>>> You received this message because you are subscribed to the Google
>>>>>> Groups "foreman-dev" group.
>>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>>> an email to foreman-dev+unsubscribe@googlegroups.com.
>>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>>
>>>>>
>>>>> --
>>>>> You received this message because you are subscribed to the Google
>>>>> Groups "foreman-dev" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send
>>>>> an email to foreman-dev+unsubscribe@googlegroups.com.
>>>>> For more options, visit https://groups.google.com/d/optout.
>>>>>
>>>>
>>>> --
>>>> You received this message because you are subscribed to the Google Groups
>>>> "foreman-dev" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send an
>>>> email to foreman-dev+unsubscribe@googlegroups.com.
>>>> For more options, visit https://groups.google.com/d/optout.
>>>>
>>>
>>>
>>>
>>> --
>>> Andrew Kofink
>>> akofink@redhat.com
>>> IRC: akofink
>>> Associate Software Engineer
>>> Red Hat Satellite
>>>
>>> --
>>> You received this message because you are subscribed to the Google Groups
>>> "foreman-dev" group.
>>> To unsubscribe from this group and stop receiving emails from it, send an
>>> email to foreman-dev+unsubscribe@googlegroups.com.
>>> For more options, visit https://groups.google.com/d/optout.
>>>
>>
>> --
>> You received this message because you are subscribed to the Google Groups "foreman-dev" group.
>> To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
>> For more options, visit https://groups.google.com/d/optout.
The greasmonkey script works great! Really helpful, thanks for sharing. For
those who are wondering (like I was), it requires the greasemonkey browser
plugin:
That being said, I don't think we should have developers relying on a
script to have links to issues on a PR, I think we should have a way of
making that link available to everyone like Andrew suggested.
-John
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch
···
On Fri, Apr 7, 2017 at 4:17 AM, Ivan Necas wrote:
I do it manually although I probably should just write a commit hook to
do
it.
I put it in the message itself because I think it’s useful to have
there in
case anyone is browsing the git log or in case we ever move away from
github.
Interesting idea. Before it gets in (+ idea for other places outside of
prprocessor scope), I’m using Tomas’s grease monkey script and has been
very helpful in past
John Mitsch
Red Hat Engineering
(860)-967-7285 <(860)%20967-7285>
irc: jomitsch
On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink akofink@redhat.com > >>>>> wrote:
I find myself copying/pasting issue numbers from GitHub PRs to a
redmine url way too much every day. It takes a bit of time, and it’s
annoying as well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with
links to
the associated issues in redmine: https://github.com/th
eforeman/prprocessor/pull/59 I’d like to hear your thoughts if you
have something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
–
You received this message because you are subscribed to the Google
Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it,
send
–
You received this message because you are subscribed to the Google
Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it,
send
I agree, it would be useful for everyone. +1 if it won't generate extra mail
notification, +0.5 if it will
···
On pátek 7. dubna 2017 14:35:41 CEST John Mitsch wrote:
> The greasmonkey script works great! Really helpful, thanks for sharing. For
> those who are wondering (like I was), it requires the greasemonkey browser
> plugin:
>
> https://addons.mozilla.org/en-US/firefox/addon/greasemonkey/ or
>
> ttps://
> chrome.google.com/webstore/detail/tampermonkey/dhdgffkkebhmkfjojejmpbldmpobf
> kfo?hl=en
>
>
> That being said, I don't think we should have developers relying on a
> script to have links to issues on a PR, I think we should have a way of
> making that link available to everyone like Andrew suggested.
–
Marek
-John
John Mitsch
Red Hat Engineering
(860)-967-7285
irc: jomitsch
I do it manually although I probably should just write a commit hook to
do
it.
I put it in the message itself because I think it’s useful to have
there in
case anyone is browsing the git log or in case we ever move away from
github.
Interesting idea. Before it gets in (+ idea for other places outside of
prprocessor scope), I’m using Tomas’s grease monkey script and has been
very helpful in past
On Thu, Apr 6, 2017 at 5:33 PM, Andrew Kofink akofink@redhat.com > > > > wrote:
Walden, you have a script that adds it, or do you do it manually for
every
issue? If the latter, then wouldn’t this save you some time?
On Thu, Apr 6, 2017 at 5:24 PM, Walden Raines wraines@redhat.com > > > > wrote:
I like it although I include the links to the issues in my actual
commit
message so it will be doubled up in my case.
On Thu, Apr 6, 2017 at 4:18 PM, John Mitsch jomitsch@redhat.com > > > > wrote:
+1 from me
John Mitsch
Red Hat Engineering
(860)-967-7285 <(860)%20967-7285>
irc: jomitsch
On Thu, Apr 6, 2017 at 3:05 PM, Andrew Kofink akofink@redhat.com > > >>>>> > > >>>>> wrote:
I find myself copying/pasting issue numbers from GitHub PRs to a
redmine url way too much every day. It takes a bit of time, and
it’s
annoying as well as easy to fix.
I’ve submitted this PR to comment on a newly submitted PR with
links to
the associated issues in redmine: https://github.com/th
eforeman/prprocessor/pull/59 I’d like to hear your thoughts if you
have something to say about it.
Andrew
–
Andrew Kofink akofink@redhat.com
IRC: akofink
Associate Software Engineer
Red Hat Satellite
–
You received this message because you are subscribed to the Google
Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it,
–
You received this message because you are subscribed to the Google
Groups “foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it,
While we're talking about modifying PrProcessor, some of the automatic
and requested task options in the MIQ bot are pretty cool - maybe we
should steal^W copy those in? :P. I can definitely see uses for
add/remove labels, at least.
I have made the change to amend the body of the pull request with the links
to the issues, which shouldn't send a new notification/email. This will be
a per-repo configuration. If you'd like for a repository to be included in
the change, please let me know via email, or comment on the pull request
<https://github.com/theforeman/prprocessor/pull/59>. I already added
katello/katello, katello/hammer-cli-csv, and katello/hammer-cli-katello.
Andrew
···
On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe wrote:
While we’re talking about modifying PrProcessor, some of the automatic
and requested task options in the MIQ bot are pretty cool - maybe we
should steal^W copy those in? :P. I can definitely see uses for
add/remove labels, at least.
If you would like to start a discussion for inclusion of MIQ bot, please
start a new thread.
···
On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe wrote:
While we’re talking about modifying PrProcessor, some of the automatic
and requested task options in the MIQ bot are pretty cool - maybe we
should steal^W copy those in? :P. I can definitely see uses for
add/remove labels, at least.
+1 to amending the original text and see how that feels in practice.
···
On Mon, Apr 10, 2017 at 10:38:11AM -0400, Andrew Kofink wrote:
> I have made the change to amend the body of the pull request with the links
> to the issues, which shouldn't send a new notification/email. This will be
> a per-repo configuration. If you'd like for a repository to be included in
> the change, please let me know via email, or comment on the pull request
> . I already added
> katello/katello, katello/hammer-cli-csv, and katello/hammer-cli-katello.
>
> - Andrew
>
> On Mon, Apr 10, 2017 at 7:23 AM, Greg Sutcliffe > wrote:
>
> > While we're talking about modifying PrProcessor, some of the automatic
> > and requested task options in the MIQ bot are pretty cool - maybe we
> > should steal^W copy those in? :P. I can definitely see uses for
> > add/remove labels, at least.
> >
> > https://github.com/ManageIQ/miq_bot?#automatic-tasks