there was another meeting of Foreman core maintainers. Last time we kicked off the mentorship program, more to be found here. Today we discussed how we improve the PR review process itself.
We’d like to officially separate code review from testing. It does not change today practise, but everyone should be aware that only reviewing the code already helps. The same applies for testing. The lifecycle of the PR should start with the code review and only after the code is acked, testing should start, to avoid unnecessary retesting. We’d like to improve the tooling, gh labels etc around this, but we didn’t discuss details and possibilities (wink wink @ekohl), let’s try it here. Few things raised - ansible repo has nice automation we can inspire from, setting up testing env with the PR applied may help, e.g. using the container we built with every commit.
One thing we know though is, we’ll start using PR assignee. Until the PR is assigned, no reviewer officially works on the review. The first thing we do when we start reviewing is, assigning ourselves to the PR. This should help with situations, when it’s not clear who owns it.
So the flow should look like this (quick sketch, probably not capturing each and every possibility)
We’d be happy to hear feedback on this and how to support the process with tooling in a way it’s clear to contributors and everyone know what is the current status.
The mantainers will meet on biweekly basis from now and assign reviewer to PRs based on current capacity. We want to start with the oldest ones. In that 2 week window, we should either decide to close or do the code review.
We also discussed the revoking permissions of inactive maintainers. While we don’t want to revoke permissions, we would like to share our concern with longer inactivity. Maintainers who are not involved for more than 6 months with the project may have lost overview, so they should proceed more carefully, if they decide to merge something. So after 6 months of inactivity we may reach out and see if the maintainer still want to be somehow involved, to set the right expectations on both sides. Activity in this case does not necessarily mean PR reviews, but contribution to the project in general. People can always give up permissions voluntarily.
Maintainers who were in that meeting, please add anything I missed.