Hello,
added a new section
<Version 90 - History - How to Create a Plugin - Foreman>
describing how to build a facet to our plugin wiki. I would be very glad if
someone could review it.
I am too involved into this feature, so I probably assuming too much about
the reader.
Thanks,
Shim.
The API documentation part where it describes .register and how to use
it is good in my opinion. The only parts I find a bit lacking are
'add_tabs' and the introduction don't have a lot of context. Also a
small example would be great. Maybe you want to add it to
https://github.com/theforeman/foreman_plugin_template?
Nice work, thanks!
···
On 02/14, sshtein@redhat.com wrote:
> Hello,
> added a new section
>
> describing how to build a facet to our plugin wiki. I would be very glad if
> someone could review it.
> I am too involved into this feature, so I probably assuming too much about
> the reader.
>
–
Daniel Lobato Garcia
@dLobatog
blog.daniellobato.me
daniellobato.me
GPG: http://keys.gnupg.net/pks/lookup?op=get&search=0x7A92D6DD38D6DE30
Keybase: https://keybase.io/elobato
+1 for Dominic. I'll add real world example links once we will have one.
I'm thinking about subscription and content facets from Katello.
Daniel, fixed the intro section and added more examples to add_tabs section.
What do you think?
Shim.
···
On Monday, February 15, 2016 at 11:20:31 AM UTC+2, Dominic Cleal wrote:
>
> On 15/02/16 09:16, Daniel Lobato Garcia wrote:
> > On 02/14, ssh...@redhat.com wrote:
> >> Hello,
> >> added a new section
> >> <
> http://projects.theforeman.org/projects/foreman/wiki/How_to_Create_a_Plugin/diff?utf8=%E2%9C%93&version=90&version_from=89&commit=View+differences>
>
> >> describing how to build a facet to our plugin wiki. I would be very
> glad if
> >> someone could review it.
> >> I am too involved into this feature, so I probably assuming too much
> about
> >> the reader.
> >>
> >
> > The API documentation part where it describes .register and how to use
> > it is good in my opinion. The only parts I find a bit lacking are
> > 'add_tabs' and the introduction don't have a lot of context. Also a
> > small example would be great. Maybe you want to add it to
> > https://github.com/theforeman/foreman_plugin_template?
>
> I think we've been trying to avoid adding an example of everything to
> the plugin template as it's in danger of being rather bloated (already
> is in places) with features that people need to *remove* for a regular
> plugin. I did ask for the pagelets example to be put on the wiki only.
>
> --
> Dominic Cleal
> dom...@cleal.org
>
I think we've been trying to avoid adding an example of everything to
the plugin template as it's in danger of being rather bloated (already
is in places) with features that people need to remove for a regular
plugin. I did ask for the pagelets example to be put on the wiki only.
···
On 15/02/16 09:16, Daniel Lobato Garcia wrote:
> On 02/14, sshtein@redhat.com wrote:
>> Hello,
>> added a new section
>>
>> describing how to build a facet to our plugin wiki. I would be very glad if
>> someone could review it.
>> I am too involved into this feature, so I probably assuming too much about
>> the reader.
>>
>
> The API documentation part where it describes .register and how to use
> it is good in my opinion. The only parts I find a bit lacking are
> 'add_tabs' and the introduction don't have a lot of context. Also a
> small example would be great. Maybe you want to add it to
> https://github.com/theforeman/foreman_plugin_template?
–
Dominic Cleal
dominic@cleal.org
