I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
IRC) for commit access to the Installer team repos.
Examples of his contributions:
Added and refactored various functionality and tests in our Puppet
modules:
Did feed back a local template modification I spotted on GitHub in a
generally usable way:
Furthermore he did review and test quite some Puppet and template PRs,
especially, but not limited to, regarding Puppet 4 and is also active in
the smart-proxy area:
+1 I think Brandons contributions are valuable and think he'd be a great
addition to the installer team.
···
On Sun, Apr 24, 2016 at 01:01:40AM +0200, Michael Moll wrote:
> I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
> IRC) for commit access to the Installer team repos.
>
> Examples of his contributions:
>
> Added and refactored various functionality and tests in our Puppet
> modules:
> https://github.com/theforeman/puppet-dhcp/commits?author=brandonweeks
> https://github.com/theforeman/puppet-foreman/commits?author=brandonweeks
> https://github.com/theforeman/puppet-foreman_proxy/commits?author=brandonweeks
> https://github.com/theforeman/puppet-puppet/commits?author=brandonweeks
>
> Did feed back a local template modification I spotted on GitHub in a
> generally usable way:
> https://github.com/theforeman/community-templates/pull/254
>
> Furthermore he did review and test quite some Puppet and template PRs,
> especially, but not limited to, regarding Puppet 4 and is also active in
> the smart-proxy area:
> https://github.com/theforeman/smart-proxy/commits?author=brandonweeks
>
> Comments welcome, also via private mail or IRC.
···
On 24/04/16 00:01, Michael Moll wrote:
> Hi,
>
> I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
> IRC) for commit access to the Installer team repos.
Commit access has been granted, thanks all, and welcome Brandon.
···
On 24/04/16 00:01, Michael Moll wrote:
> Hi,
>
> I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
> IRC) for commit access to the Installer team repos.
Michael checked with me privately before nominating and I agreed. I've
read though the contributor guides and understand the expectations.
–Brandon
···
On Wednesday, April 27, 2016 at 7:50:14 AM UTC-7, Greg Sutcliffe wrote:
>
> On 26 April 2016 at 10:15, Dominic Cleal <dom...@cleal.org > > wrote:
>
>> On 24/04/16 00:01, Michael Moll wrote:
>> > Hi,
>> >
>> > I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
>> > IRC) for commit access to the Installer team repos.
>>
>> I'd agree, thanks for proposing it.
>>
>
> +1, but I'd like to hear from Brandon that he *wants* the access :)
>
It looks unlikely that anyone will object, so just as a reminder, on
Sunday he should get in the Installer team. I would do it myself but I
don't have access over that repo.
···
On 04/27, Brandon Weeks wrote:
> Michael checked with me privately before nominating and I agreed. :) I've
> read though the contributor guides and understand the expectations.
>
> --Brandon
>
> On Wednesday, April 27, 2016 at 7:50:14 AM UTC-7, Greg Sutcliffe wrote:
> >
> > On 26 April 2016 at 10:15, Dominic Cleal <dom...@cleal.org > > > wrote:
> >
> >> On 24/04/16 00:01, Michael Moll wrote:
> >> > Hi,
> >> >
> >> > I'd like to nominate Brandon Weeks (brandonweeks on GitHub, brandon on
> >> > IRC) for commit access to the Installer team repos.
> >>
> >> I'd agree, thanks for proposing it.
> >>
> >
> > +1, but I'd like to hear from Brandon that he *wants* the access :)
> >
>
> --
> You received this message because you are subscribed to the Google Groups "foreman-dev" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to foreman-dev+unsubscribe@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.
