There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn't seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output'
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph
Joseph,
That failing test is a bug [1] in Facter. Can you try installing a more recent version and see if that test passes?
-S
- http://projects.puppetlabs.com/issues/17407
···
----- Original Message -----
From: "Joseph Magen"
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 10:18:42 AM
Subject: [foreman-dev] Organizations and Locations - new pull request
There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn’t seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output’
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph
Looks like this is a mix of Facter versions on the same system:
http://projects.puppetlabs.com/issues/17407
Perhaps check for gem versus system packages?
···
On 21/01/13 15:18, Joseph Magen wrote:
> There is a new pull request for Organizations and Locations (refactored)
>
> https://github.com/theforeman/foreman/pull/354
>
> 1) There is one failed test, that doesn't seem to relate to the code that was changed?
>
> test_create_valid_facter_yaml_output(FactValuesControllerTest):
> NoMethodError: undefined method `enum_lsdev' for Facter::Util::Processor:Module
> test/functional/fact_values_controller_test.rb:31:in `test_create_valid_facter_yaml_output'
–
Dominic Cleal
Red Hat Engineering
Thanks. Facter is updated and the failing test went away.
···
----- Original Message -----
From: "Sam Kottler"
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:21:23 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Joseph,
That failing test is a bug [1] in Facter. Can you try installing a more recent version and see if that test passes?
-S
- http://projects.puppetlabs.com/issues/17407
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 10:18:42 AM
Subject: [foreman-dev] Organizations and Locations - new pull request
There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn’t seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output’
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph
Amos' UI wizard edits are incorporated in the pull request
The last remaining item is fixing the clone function.
···
----- Original Message -----
From: "Joseph Magen"
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:55:46 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Thanks. Facter is updated and the failing test went away.
----- Original Message -----
From: “Sam Kottler” skottler@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:21:23 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Joseph,
That failing test is a bug [1] in Facter. Can you try installing a more recent version and see if that test passes?
-S
- http://projects.puppetlabs.com/issues/17407
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 10:18:42 AM
Subject: [foreman-dev] Organizations and Locations - new pull request
There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn’t seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output’
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph
Hi all,
The orgs and locations branch is now merged!! Please have a look. It will soon be part of RC5
Joseph
···
----- Original Message -----
From: "Joseph Magen"
To: foreman-dev@googlegroups.com
Sent: Wednesday, January 23, 2013 6:38:41 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Amos’ UI wizard edits are incorporated in the pull request
The last remaining item is fixing the clone function.
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:55:46 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Thanks. Facter is updated and the failing test went away.
----- Original Message -----
From: “Sam Kottler” skottler@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:21:23 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Joseph,
That failing test is a bug [1] in Facter. Can you try installing a more recent version and see if that test passes?
-S
- http://projects.puppetlabs.com/issues/17407
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 10:18:42 AM
Subject: [foreman-dev] Organizations and Locations - new pull request
There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn’t seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output’
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph
Excellent job, that makes it so much more usable. With a few clicks,
and one stack trace later (PR filed :)), all hosts were imported into a
brand new location and org.
It's a nice workflow that I think would be useful to emulate for #2128,
setting up an admin user for new installs. Maybe other things too, such
as registering a smart proxy or trusted host for the puppetmaster auth
stuff?
···
--
Dominic Cleal
Red Hat Engineering
On 24/01/13 15:39, Joseph Magen wrote:
Hi all,
The orgs and locations branch is now merged!! Please have a look. It will soon be part of RC5
Joseph
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Wednesday, January 23, 2013 6:38:41 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Amos’ UI wizard edits are incorporated in the pull request
The last remaining item is fixing the clone function.
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:55:46 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Thanks. Facter is updated and the failing test went away.
----- Original Message -----
From: “Sam Kottler” skottler@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 5:21:23 PM
Subject: Re: [foreman-dev] Organizations and Locations - new pull request
Joseph,
That failing test is a bug [1] in Facter. Can you try installing a more recent version and see if that test passes?
-S
- http://projects.puppetlabs.com/issues/17407
----- Original Message -----
From: “Joseph Magen” jmagen@redhat.com
To: foreman-dev@googlegroups.com
Sent: Monday, January 21, 2013 10:18:42 AM
Subject: [foreman-dev] Organizations and Locations - new pull request
There is a new pull request for Organizations and Locations (refactored)
https://github.com/theforeman/foreman/pull/354
- There is one failed test, that doesn’t seem to relate to the code that was changed?
test_create_valid_facter_yaml_output(FactValuesControllerTest):
NoMethodError: undefined method enum_lsdev' for Facter::Util::Processor:Module test/functional/fact_values_controller_test.rb:31:in
test_create_valid_facter_yaml_output’
- Amos, can you look at why the validation flash error message is not displaying?
Thanks,
Joseph