Problems running integration tests?

Jonathon_Turel · July 11, 2019, 2:16pm

If you run the Foreman integration tests locally and noticed that they are mysteriously failing, well, that’s because of a recent change[1] that was merged.

The change involved the removal of the webpack:try_compile rake task as it was found to be unnecessary when running tests - and in general. The upside is that Katello and Foreman developers will enjoy slightly faster test runs (especially via Jenkins) because webpack isn’t being compiled unnecessarily.

The downside is that before running integration tests locally you’ll need to compile the webpack assets: bundle exec rake webpack:compile and you should be good to go.

Let me know if you see anything out of the ordinary as a result of this change!

[1] https://github.com/theforeman/foreman/pull/6876

lzap · July 19, 2019, 1:34pm

Do we want to do the webpack compilation step as a dependant rake action? I guess that is the only proper solution although it will make tests much slower. We should probably allow a way to skip the compilation for quick runs, but this should be explicit (you know what you are doing).

ekohl · July 19, 2019, 1:44pm

It already is, but plugins add all their tests to jenkins:unit rather than properly splitting them out.

github.com

theforeman/foreman_plugin_template/blob/3376da2c9b603f9285fa922cc2865d25ac9b5aeb/lib/tasks/foreman_plugin_template_tasks.rake#L46


  end


  Rake::Task['rubocop_foreman_plugin_template'].invoke
end
end


Rake::Task[:test].enhance ['test:foreman_plugin_template']


load 'tasks/jenkins.rake'
if Rake::Task.task_defined?(:'jenkins:unit')
Rake::Task['jenkins:unit'].enhance ['test:foreman_plugin_template', 'foreman_plugin_template:rubocop']
end

The proper solution would be to split it out in plugins as well.