Puppet-foreman_network repository

Dominic_Cleal · January 14, 2015, 10:44am

Hi (Martin specifically),

···

> -------- Forwarded Message -------- > Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications > Date: Wed, 14 Jan 2015 02:05:47 -0800 > From: GitHub > To: dcleal@redhat.com > > > Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. > > theforeman/puppet-foreman_network created by mbacovsky > Puppet module for configuration of network > https://github.com/theforeman/puppet-foreman_network

Could you elaborate on what this is please? I moved it into the
installer team (for ACLs) as that would appear to be its home.

I think we’d ordinarily use puppetlabs-firewall and an existing
networking module (of which there are a number of well-regarded ones)
rather than creating something new.

–
Dominic Cleal
Red Hat Engineering

ekohl · January 14, 2015, 10:50am

My thoughts exactly.

···

On Wed, Jan 14, 2015 at 10:44:12AM +0000, Dominic Cleal wrote: > Hi (Martin specifically), > > > -------- Forwarded Message -------- > > Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications > > Date: Wed, 14 Jan 2015 02:05:47 -0800 > > From: GitHub > > To: dcleal@redhat.com > > > > > > Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. > > > > theforeman/puppet-foreman_network created by mbacovsky > > Puppet module for configuration of network > > https://github.com/theforeman/puppet-foreman_network > > Could you elaborate on what this is please? I moved it into the > installer team (for ACLs) as that would appear to be its home. > > I think we'd ordinarily use puppetlabs-firewall and an existing > networking module (of which there are a number of well-regarded ones) > rather than creating something new.

mbacovsky · January 19, 2015, 3:49pm

Sorry, I missed the post…

I'm working on moving network configuration parts from
staypuft-installer. Part of the installer is puppet manifest [1] that is
run in separate puppet run and is responsible for pre-configuring
network interface (if necessary) before the installer is run. It is
useful for LiveCD when run on a clean box. It seems better to move this
manifest to separate puppet module and manage it in same manner as the
other modules.

Does it make sense?

Martin

[1]

github.com

theforeman/foreman-installer-staypuft/blob/master/modules/foreman/manifests/plugin/staypuft_network.pp

# = Staypuft Network
#
# Configures networking according to values gathered by wizard, it does following actions
#   * configures gateway
#   * configures interface's IP address, netmask and DNS servers
#   * adds hosts record if missing
#   * configures firewall in a non-destructive way (leaves all existing rules untouched)
#
# === Parameters:
#
# $interface::            Which interface should this class configure
#
# $ip::                   What IP address should be set
#
# $netmask::              What netmask should be set
#
# $gateway::              What is the gateway for this machine
#
# $dns::                  DNS forwarder to use as secondary nameserver
#

This file has been truncated. show original

···

On 01/14/2015 11:44 AM, Dominic Cleal wrote: > Hi (Martin specifically), > >> -------- Forwarded Message -------- >> Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications >> Date: Wed, 14 Jan 2015 02:05:47 -0800 >> From: GitHub >> To: dcleal@redhat.com >> >> >> Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. >> >> theforeman/puppet-foreman_network created by mbacovsky >> Puppet module for configuration of network >> https://github.com/theforeman/puppet-foreman_network > Could you elaborate on what this is please? I moved it into the > installer team (for ACLs) as that would appear to be its home. > > I think we'd ordinarily use puppetlabs-firewall and an existing > networking module (of which there are a number of well-regarded ones) > rather than creating something new. >

Gwmngilfen · January 14, 2015, 11:58am

A further +1 for using existing modules, if possible.

···

On 14 January 2015 at 10:50, Ewoud Kohl van Wijngaarden wrote: > On Wed, Jan 14, 2015 at 10:44:12AM +0000, Dominic Cleal wrote: >> Hi (Martin specifically), >> >> > -------- Forwarded Message -------- >> > Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications >> > Date: Wed, 14 Jan 2015 02:05:47 -0800 >> > From: GitHub >> > To: dcleal@redhat.com >> > >> > >> > Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. >> > >> > theforeman/puppet-foreman_network created by mbacovsky >> > Puppet module for configuration of network >> > https://github.com/theforeman/puppet-foreman_network >> >> Could you elaborate on what this is please? I moved it into the >> installer team (for ACLs) as that would appear to be its home. >> >> I think we'd ordinarily use puppetlabs-firewall and an existing >> networking module (of which there are a number of well-regarded ones) >> rather than creating something new. > > My thoughts exactly.

Dominic_Cleal · January 20, 2015, 8:19am

This looks to mostly contain firewall configuration around Foreman, so
it should live in the existing puppet-foreman module IMHO.

It does at least seem to use external modules, so those would be added
as dependencies (we'll have to evaluate whether they're sensible choices).

···

On 19/01/15 15:49, Martin Bačovský wrote: > On 01/14/2015 11:44 AM, Dominic Cleal wrote: >> Hi (Martin specifically), >> >>> -------- Forwarded Message -------- >>> Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications >>> Date: Wed, 14 Jan 2015 02:05:47 -0800 >>> From: GitHub >>> To: dcleal@redhat.com >>> >>> >>> Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. >>> >>> theforeman/puppet-foreman_network created by mbacovsky >>> Puppet module for configuration of network >>> https://github.com/theforeman/puppet-foreman_network >> Could you elaborate on what this is please? I moved it into the >> installer team (for ACLs) as that would appear to be its home. >> >> I think we'd ordinarily use puppetlabs-firewall and an existing >> networking module (of which there are a number of well-regarded ones) >> rather than creating something new. >> > Sorry, I missed the post... > > I'm working on moving network configuration parts from > staypuft-installer. Part of the installer is puppet manifest [1] that is > run in separate puppet run and is responsible for pre-configuring > network interface (if necessary) before the installer is run. It is > useful for LiveCD when run on a clean box. It seems better to move this > manifest to separate puppet module and manage it in same manner as the > other modules. > > Does it make sense? > > Martin > > [1] > https://github.com/theforeman/foreman-installer-staypuft/blob/master/modules/foreman/manifests/plugin/staypuft_network.pp

–
Dominic Cleal
Red Hat Engineering

Dominic_Cleal · January 20, 2015, 10:54am

We've continued the discussion on
https://github.com/theforeman/puppet-foreman_network/pull/1

···

On 20/01/15 08:19, Dominic Cleal wrote: > On 19/01/15 15:49, Martin Bačovský wrote: >> On 01/14/2015 11:44 AM, Dominic Cleal wrote: >>> Hi (Martin specifically), >>> >>>> -------- Forwarded Message -------- >>>> Subject: [GitHub] Subscribed to theforeman/puppet-foreman_network notifications >>>> Date: Wed, 14 Jan 2015 02:05:47 -0800 >>>> From: GitHub >>>> To: dcleal@redhat.com >>>> >>>> >>>> Hey there, we're just writing to let you know that you've been automatically subscribed to a repository on GitHub. >>>> >>>> theforeman/puppet-foreman_network created by mbacovsky >>>> Puppet module for configuration of network >>>> https://github.com/theforeman/puppet-foreman_network >>> Could you elaborate on what this is please? I moved it into the >>> installer team (for ACLs) as that would appear to be its home. >>> >>> I think we'd ordinarily use puppetlabs-firewall and an existing >>> networking module (of which there are a number of well-regarded ones) >>> rather than creating something new. >>> >> Sorry, I missed the post... >> >> I'm working on moving network configuration parts from >> staypuft-installer. Part of the installer is puppet manifest [1] that is >> run in separate puppet run and is responsible for pre-configuring >> network interface (if necessary) before the installer is run. It is >> useful for LiveCD when run on a clean box. It seems better to move this >> manifest to separate puppet module and manage it in same manner as the >> other modules. >> >> Does it make sense? >> >> Martin >> >> [1] >> https://github.com/theforeman/foreman-installer-staypuft/blob/master/modules/foreman/manifests/plugin/staypuft_network.pp > > This looks to mostly contain firewall configuration around Foreman, so > it should live in the existing puppet-foreman module IMHO. > > It does at least seem to use external modules, so those would be added > as dependencies (we'll have to evaluate whether they're sensible choices).

–
Dominic Cleal
Red Hat Engineering