React form inputs integration to rails forms

[ohadlevy]

@ezr-ondrej

1. Tests

• Structure of components is not consistent in a matter of test placing so I do not know where to put .test.js , fixtures.js for sure
• Test tools - I am not sure if snapshot testing is the way to go and the test helpers are not complete and above that not consitently used so I am not sure how to test in a right way.
• Fixtures files reusability for the storybooks - there are different example across code base and I am not certain what is the right way as a onboarder.

2. Redux usage

• Inconsistancy again - I can find a lot of examples, I am not sure which is the right one.
• Usage - where to use redux and where not
• Uniqueness of the state space usage - there is problem with the component being on the page more times (being solved as we speek by Ron, but very young)

some of the code is “older” and doesn’t follow the latest definitions that are defined at [1] - I assume you didn’t read it already?

There is even a code generator (React Component Generator) that follow that, the fact that its not known to developers is probably leading to the important point that enough communication is probably not happening…I know the UI team does try to send a newsletter( e.g. Foreman UX newsletter - January 2019, but maybe that’s not often enough…)

[1] https://theforeman.github.io/foreman/?selectedKind=Introduction&selectedStory=Getting%20started&full=0&addons=1&stories=1&panelRight=0&addonPanel=storybook%2Factions%2Factions-panel