Hi,
I've submitted two pull requests for #1809. This is the most substantial amount of rails/ruby code I've written, so I'd really appreciate some feed on it, even nitpicky things.
Maybe it might make sense to give you a demo of how the realm integration works?
https://github.com/theforeman/foreman/pull/1061
https://github.com/theforeman/smart-proxy/pull/115
Thanks,
Stephen
···
--
Stephen Benjamin
stephen@bitbin.de
Great, thanks Stephen. Would you like to do a deep dive/demo on Tuesday?
Dominic Cleal
Red Hat Engineering
···
On 27/11/13 13:31, Stephen Benjamin wrote:
> Hi,
>
> I've submitted two pull requests for #1809. This is the most
> substantial amount of rails/ruby code I've written, so I'd really
> appreciate some feed on it, even nitpicky things.
>
> Maybe it might make sense to give you a demo of how the realm
> integration works?
>
> https://github.com/theforeman/foreman/pull/1061
> https://github.com/theforeman/smart-proxy/pull/115
Could do – but it would have to be in the evening, is 19:30 too late?
···
On Nov 27, 2013, at 2:39 PM, Dominic Cleal wrote:
Signed PGP part
On 27/11/13 13:31, Stephen Benjamin wrote:
Hi,
I’ve submitted two pull requests for #1809. This is the most
substantial amount of rails/ruby code I’ve written, so I’d really
appreciate some feed on it, even nitpicky things.
Maybe it might make sense to give you a demo of how the realm
integration works?
https://github.com/theforeman/foreman/pull/1061
https://github.com/theforeman/smart-proxy/pull/115
Great, thanks Stephen. Would you like to do a deep dive/demo on Tuesday?
–
Stephen Benjamin
stephen@bitbin.de
That works, will catch up with you on IRC.
Dominic Cleal
Red Hat Engineering
···
On 27/11/13 14:50, Stephen Benjamin wrote:
>
> On Nov 27, 2013, at 2:39 PM, Dominic Cleal > wrote:
>
>> Signed PGP part On 27/11/13 13:31, Stephen Benjamin wrote:
>>> Hi,
>>>
>>> I've submitted two pull requests for #1809. This is the most
>>> substantial amount of rails/ruby code I've written, so I'd
>>> really appreciate some feed on it, even nitpicky things.
>>>
>>> Maybe it might make sense to give you a demo of how the realm
>>> integration works?
>>>
>>> https://github.com/theforeman/foreman/pull/1061
>>> https://github.com/theforeman/smart-proxy/pull/115
>>
>> Great, thanks Stephen. Would you like to do a deep dive/demo on
>> Tuesday?
>
> Could do -- but it would have to be in the evening, is 19:30 too
> late?