Redmine issues check has started to fail

ekohl · August 27, 2024, 3:42pm

Currently there’s an issue with the PR processor application. I think GitHub changed their webhooks and the framework we use isn’t able to deal with it so I opened an issue:

github.com/sanitizers/octomachinery

Webhooks have started to fail with `TypeError: init() got an unexpected keyword argument 'client_id'`

opened 03:33PM - 27 Aug 24 UTC

ekohl

At 2024-08-27 14:00:25 I saw the last successful webhook delivery. After that it… has started to fail with: ``` Traceback (most recent call last): File "/opt/app-root/src/app.py", line 5, in <module> run_prprocessor_app() File "/opt/app-root/src/prprocessor/__main__.py", line 513, in run_prprocessor_app run_app( File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/app/server/runner.py", line 71, in run run_until_complete(run_server_forever, config, event_routers) File "/opt/app-root/lib64/python3.9/site-packages/anyio/__init__.py", line 72, in run return asynclib.run(func, *args, **backend_options) # type: ignore File "/opt/app-root/lib64/python3.9/site-packages/anyio/_backends/_asyncio.py", line 114, in run raise exception File "/opt/app-root/lib64/python3.9/site-packages/anyio/_backends/_asyncio.py", line 76, in wrapper retval = await func(*args) File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/utils/asynctools.py", line 15, in async_func_wrapper return await async_func(*args, **kwargs) File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/app/server/machinery.py", line 134, in run_forever await _prepare_github_app(github_app) File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/app/server/machinery.py", line 64, in _prepare_github_app await github_app.log_installs_list() File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/github/api/app_client.py", line 71, in log_installs_list installations = await self.get_installations() File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/github/api/app_client.py", line 133, in get_installations async for install in amap( File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/utils/asynctools.py", line 83, in amap yield await try_await(callback(async_value)) File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/utils/asynctools.py", line 68, in try_await return await potentially_awaitable File "/opt/app-root/lib64/python3.9/site-packages/octomachinery/utils/asynctools.py", line 89, in callback_wrapper return await try_await(callback(**args_dict)) TypeError: __init__() got an unexpected keyword argument 'client_id' ``` The container was built 25 days ago and runs https://github.com/theforeman/prprocessor. I've seen this happen before when GitHub changed their webhooks, but from the trace it's not obvious to me where it's failing. ## Upvote & Fund - We're using [Polar.sh](https://polar.sh/sanitizers) so you can upvote and help fund this issue. - We receive the funding once the issue is completed & confirmed by you. - Thank you in advance for helping prioritize & fund our backlog. <a href="https://polar.sh/sanitizers/octomachinery/issues/66"> <picture> <source media="(prefers-color-scheme: dark)" srcset="https://polar.sh/api/github/sanitizers/octomachinery/issues/66/pledge.svg?darkmode=1"> <img alt="Fund with Polar" src="https://polar.sh/api/github/sanitizers/octomachinery/issues/66/pledge.svg"> </picture> </a>

I understand this is inconvenient and we’ll try to get this sorted.

ekohl · August 28, 2024, 9:59am

The issue has been resolved:

Redelivering failed webhooks via the GitHub UI doesn’t scale well (there’s no bulk option) so if you’re stuck then I’d recommend pushing a new commit to retrigger the check.