All,
Today we merged and updated both Redmine and the prprocessor to support
multiple pull requests for a given issue. For those that use the pull
request field on Redmine issues, this means that if multiple pull requests
have targeted a given issue through fixes/refs, the pull request field
should now record and display all associated. If you see issues with this
functionality, or unexpected behavior from the prprocessor please let us
know!
I just had one of my issues reassigned to lzap because he added a PR that
refs it (Bug #8800: Table cells should clip with tooltip only if text actually overflows - Foreman), the prprocessor
should only assign the issue to the PR author if it's the first PR for the
issue.
All,
Today we merged and updated both Redmine and the prprocessor to support
multiple pull requests for a given issue. For those that use the pull
request field on Redmine issues, this means that if multiple pull requests
have targeted a given issue through fixes/refs, the pull request field
should now record and display all associated. If you see issues with this
functionality, or unexpected behavior from the prprocessor please let us
know!–
Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University–
You received this message because you are subscribed to the Google Groups
"foreman-dev" group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Have a nice day,
Tomer Brisker
Red Hat Engineering
The service had a few errors over the weekend as it wasn't updating
Redmine tickets correctly.
I've now fixed this and redelivered all failed GitHub webhooks on
theforeman/foreman, but please check that your open PRs are correctly
labelled if you've recently updated them.
–
Dominic Cleal
dominic@cleal.org
Thanks for pointing that case out! I've opened a PR to the prprocessor to
only set the assigned_to field if it is not already set:
https://github.com/theforeman/prprocessor/pull/31
Eric
I just had one of my issues reassigned to lzap because he added a PR that
refs it (http://projects.theforeman.org/issues/8800), the prprocessor
should only assign the issue to the PR author if it’s the first PR for the
issue.On Fri, Oct 30, 2015 at 4:53 PM, Eric D Helms ericdhelms@gmail.com > wrote:
All,
Today we merged and updated both Redmine and the prprocessor to support
multiple pull requests for a given issue. For those that use the pull
request field on Redmine issues, this means that if multiple pull requests
have targeted a given issue through fixes/refs, the pull request field
should now record and display all associated. If you see issues with this
functionality, or unexpected behavior from the prprocessor please let us
know!–
Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.–
Have a nice day,
Tomer Brisker
Red Hat Engineering–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
–
Eric D. Helms
Red Hat Engineering
Ph.D. Student - North Carolina State University
Is this a known issue of the PR processor? It looks like when you update a
PR it doesn’t get assigned or reassigned to the correct issue:
https://github.com/Katello/katello/pull/5574
This PR should be assigned to this issue:
But it’s on this one instead:
David
On 30/10/15 14:53, Eric D Helms wrote:
All,
Today we merged and updated both Redmine and the prprocessor to support
multiple pull requests for a given issue. For those that use the pull
request field on Redmine issues, this means that if multiple pull
requests have targeted a given issue through fixes/refs, the pull
request field should now record and display all associated. If you see
issues with this functionality, or unexpected behavior from the
prprocessor please let us know!The service had a few errors over the weekend as it wasn’t updating
Redmine tickets correctly.I’ve now fixed this and redelivered all failed GitHub webhooks on
theforeman/foreman, but please check that your open PRs are correctly
labelled if you’ve recently updated them.–
Dominic Cleal
dominic@cleal.org–
You received this message because you are subscribed to the Google Groups
“foreman-dev” group.
To unsubscribe from this group and stop receiving emails from it, send an
email to foreman-dev+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
The PR hasn't been updated (triggering a GitHub "synchronised" webhook)
since the title was changed. Change the title and then push to the
branch and it would have updated.
A couple of possible fixes:
a) update PR links on the PR closed event, prprocessor skips this now
(https://github.com/theforeman/prprocessor/blob/master/app.rb#L29)
b) change ticket number parsing to commit messages instead of PR titles
(https://github.com/theforeman/prprocessor/blob/master/github/pull_request.rb#L17)
–
Dominic Cleal
dominic@cleal.org