Release team meeting agenda 2022-02-09

ekohl · February 8, 2022, 1:06pm

Foreman 3.2.0

Installer module releases done
Roadmap
Redmine TODO issues
- Bug #34409: Revert identifying CentOS Stream as CentOS_Stream - Foreman

Foreman 3.1.2

Foreman 3.0.2

Roadmap
Redmine TODO issues
- Bug #33897: Mismatch report fails with 'uninitialized constant Environment' - Foreman should be cloned and modified to describe the real issue

Katello 4.4.0

Roadmap
(@ekohl) Creating a release TODO and process

Zhunting · February 9, 2022, 2:34pm

Foreman 3.2.0:

We waiting on a specific PR that is under discussion that is required before branching https://github.com/theforeman/foreman/pull/9098
Once fixed we should be prepared for branching
@upadhyeammit indicated he’s ready to branch as well

Foreman 3.1.2:

Nothing specific to say, but @upadhyeammit agreed to look through meeting notes on 3.1.2 to find out if there are any issues that need to be looked at.

Katello 4.4.0:

Initial config has been merged to tool belt. Issues on redmine have been moved, and @iballou is ready to branch.

Other Business:

@ekohl wanted to discuss a difference between the Foreman and Katello release process in regard to fixed in versions of issues in redmine. The PRprocessor as it stands looks for the the newest version made on redmine and fills in an issues fixed in version to that version. Because Katello generally precreates versions ahead we have issues that go to 4.5 but should be on 4.4.
@ekohl requested that we change the PRprocessor to not function as it currently does, and instead gets the correct fixed in version for these Katello issues so that foreman and Katello are more in line in release process
@iballou agreed to look into the older redmines that may have incorrect fixed in versions and helping with the change needed for the PRprocessor.

ekohl · February 9, 2022, 3:30pm

I wasn’t entirely suggesting to change the prprocessor but rather make sure that what it does and how Katello uses versions in Redmine align.

This is a bit more verbose than what I said during the meeting, but the background is here.

Right now this is the code that determines the version to use:

github.com

theforeman/prprocessor/blob/651f790cbd1c009bb05a9b900fbd18692f69ab0a/prprocessor/redmine.py#L109-L129

    
      
          def get_latest_open_version(project: Project, version_prefix: str) \
                  -> Optional[CustomField]:
              versions = _filter_versions(project.versions.filter(status='open'), version_prefix)
          
          
    try:
                  return sorted(versions, key=lambda version: LooseVersion(version.name))[-1]
              except ValueError:
                  logger.exception('Failed to parse version for %s: %s', project.name, versions)
                  return None
              except IndexError:
                  logger.warning('No versions found for %s', project.name)
                  return None
          
          

          
def _filter_versions(versions: Iterable[CustomField],
                               version_prefix: str) -> Generator[CustomField, None, None]:
              for version in versions:
                  if version.name.startswith(version_prefix):
                      name = version.name.removeprefix(version_prefix)
                      if name and name[0].isdigit():
                          yield version

This uses the following config:

github.com

theforeman/prprocessor/blob/651f790cbd1c009bb05a9b900fbd18692f69ab0a/prprocessor/config/repos.yaml#L222-L225

    
      
          Katello/katello:
            redmine: katello
            redmine_required: true
            redmine_version_prefix: "Katello "

The key bit is that it has a version prefix (Katello ) which is stripped off. Anything that’s non-empty and starts with a digit is considered a version. The highest version number is picked as “Fixed in version”.

Since a version 4.5.0 already exists today, it sets the Fixed in version to that whenever something is merged. Even though Katello’s git master is currently 4.4.0(-pre). The result is a list of issues with an incorrect Fixed in version.

If Katello instead created a version Katello Next (or Katello Future), it wouldn’t be considered by the prprocessor and Fixed in version would be correct. This in turn allows creating a Katello 4.4 TODO that’s correct.

It does mean that on branching the Katello Next version should be renamed to Katello 4.5.0 and a new Katello Next should be created.

For Foreman there’s less planning so there is no concept of a Next. However, this whole story is the reason why these steps in Foreman’s branching process are last:

github.com

theforeman/tool_belt/blob/33d2b792b7bf66095384aa405b17f93653fb0a29/procedures/foreman/branch.md.erb#L143-L145

    
      
          - Create Redmine versions
            - [ ] Add next version number (<%= develop %>.0) and make sure it is shared with subprojects in [foreman](https://projects.theforeman.org/projects/foreman/settings/versions)
            - [ ] Add first patch release (<%= release %>.1) and make sure it is shared with subprojects in [foreman](https://projects.theforeman.org/projects/foreman/settings/versions)

Addendum: this was actually a simplification. There is an additional part when it comes to stable branches. The config version prefix gets an additional version bit attached:

github.com

theforeman/prprocessor/blob/651f790cbd1c009bb05a9b900fbd18692f69ab0a/prprocessor/main.py#L342-L363

    
      
          if target_branch.endswith('-stable'):
              # Handle a branch like 3.0-stable. This means we get an additional prefix of 3.0. which
              # allows get_latest_open_version to find the right version
              version_prefix = f'{target_branch.removesuffix("-stable")}.'
          elif target_branch in ('main', 'master', 'develop', 'deb/develop', 'rpm/develop'):
              # Development branches don't have a version prefix so they really use the latest
              version_prefix = ''
          else:
              logger.info('Unable to set fixed in version for %s branch %s in PR %s',
                          repository, target_branch, pull_request['number'])
              return
          
          
try:
              config = get_config(repository)
          except UnconfiguredRepository:
              return
          else:
              if not config.project:
                  logger.info('Repository for %s not found', repository)
                  return

This file has been truncated. show original

For Foreman when a PR is merged into 3.0-stable, it looks for Foreman 3.0. as a prefix. This means it can select Foreman 3.0.2 on cherry pick merging. Katello uses KATELLO-x.y for stable branches. If desired, the prprocessor can be taught to also set the right Fixed in version on cherry pick PRs.

I should really wrap this up and add it to prprocessor’s README.