Howdy,
This is going to seem like a perhaps silly request but it has the ability to make some things easier. Currently the foreman_docker git repository is named foreman-docker
with a hyphen. The gem itself is named foreman_docker
which provides a disjoint. When trying to automate and generalize this discrepancy causes special branches to exist in code for this single case. For example, if you attempt to spin up a dev environment with Forklift and specify foreman_docker as a plugin, you will get bundle install errors because the directory it checks out to ‘foreman-docker’ does not match the :name
parameter [1] and thus it cannot find the gemspec. You might ask, the name
parameter is not required why not drop it and let bundler find the gemspec for us! That would be great except that multiple projects (foreman_ansible, foreman_remote_execution, foreman-tasks) follow a design of having multiple gemspecs in their top level directory because multiple gems are generated from a single git repository.
Thoughts? I’d really love to avoid specializing generalized code and this change would bring the git repository in line with the gem name providing parity.
[1] https://github.com/theforeman/puppet-katello_devel/blob/master/templates/plugin.local.rb.erb#L1