Apologies for taking so long to get back to you, I was indisposed for a
bit. After some discussion with the other committers this is the feedback
we arrived on. If you have questions, would like clarification please ask
as we are trying a new process with this procedure.
Core - Nae
We would like to see at least two major reviews of two bigger change and
implementation of a feature or substantial PR
Installer - Nae
Close but we'd like to see work and reviews across multiple puppet
modules
Website - Yea
Not as strong on requirements here, edits and reviews have been good
Pulp - 50/50
Has done some review, knows this area due to past experience, the
biggest piece is Runcible and feeling comfortable with maintaining it
UI - Nae
We'd like to see at least one major review of a major change and
implementation of a feature
Packaging - Nae
We'd like to see a couple of reviews and PRs targeted in this area as
well as demonstrate knowledge of how to build packages
Eric
···
On Thu, Oct 29, 2015 at 3:24 PM, Eric D Helms wrote:
Howdy Chris,
Thanks for the inquiry and data, we are taking your request under
advisement and will get back to you with our feedback soon.
> Hey Chris,
>
> Apologies for taking so long to get back to you, I was indisposed for a
> bit. After some discussion with the other committers this is the feedback
> we arrived on. If you have questions, would like clarification please ask
> as we are trying a new process with this procedure.
>
> Core - Nae
> * We would like to see at least two major reviews of two bigger change and
> implementation of a feature or substantial PR
> Installer - Nae
> * Close but we'd like to see work and reviews across multiple puppet
> modules
> Website - Yea
> * Not as strong on requirements here, edits and reviews have been good
> Pulp - 50/50
> * Has done some review, knows this area due to past experience, the
> biggest piece is Runcible and feeling comfortable with maintaining it
> UI - Nae
> * We'd like to see at least one major review of a major change and
> implementation of a feature
> Packaging - Nae
> * We'd like to see a couple of reviews and PRs targeted in this area as
> well as demonstrate knowledge of how to build packages
>
Thanks for the review. I was looking at the old write-access docs when I
put in the request, before it was split up by team. I'll use the
per-team criteria for future requests.