IIRC we introduced disable-system-checks because we had to put some checks into the hooks and the skip-checks-i-know-better handled only those things put into actual checks/. That leans me towards dropping checks/ given they lack all of the contextual information that hooks/ have.
I tend to agree that checks are limited and hooks provide more context that’s useful. However, it’s still a bad UX to have two parameters for pretty much the same thing. In a hook you can also check if the --skip-checks-i-know-better parameter was supplied so that’s one potential implementation. I’d just like to converge on one.
We can also think about a better implementation where the parameter can accept arguments to skip individual checks. With this we can skip the sizing check in our CI without disabling all others to get better coverage.
Fair. I think enough users know about disable-system-checks that I would opt for removing skip-checks-i-know-better in favor of disable-system-checks. I’d also suggest we drop checks/ in favor of a new hook for checks.
