I was already very interested in this when it was brought up on the devconf, great that this is getting progess now!
Some thoughts when playing with the current PR:
- After reading the previous thread, the location of the searchbox makes a lot of sense in the navigation, but the top bar is also not that much used, lots of blank space, maybe on the right like mentioned here? Also the nav bar can be hidden, which means the search is also out of sight then.
- This overlaying white box makes the search very pretty when not in use, but it makes you click twice until you can write in there, it doesn’t reset correctly if you just click outside of the box instead of clicking the X (if combined with #1 it might just be the collapsed view/search button)
- Also as Maximilian is saying it the subpage hints are very helpful (the wordwrapping needs some love)
- I would really be looking forward to a global page shortcut, which is somewhere mentioned (in the box description, tooltip, …), the hard part might be here finding a shortcut that either works universally on all keyboard layouts or having different once for different layouts (the previously mentioned ` is pretty hard to reach on a German QUERTZ), I was first thinking of Ctrl + F but that will definitely break stuff, so Ctrl + Shift + F might be the next best thing (not in use by browsers as far as I understand it)
- It would be perfect if the 1st item in the search results list would be selected by default after typing, this would make it possible to hit enter right away without the need of navigating to one of the results