Ruby 1.9 support in Foreman-proxy

Hi all,

I've just created a pullreq for Ruby 1.9 support in the smart proxy,
while preserving 1.8 support. It seems to work for me on my 1.8 and
1.9 proxies, but I'd love more testing. If anybody wants to have a
play, you can find it at https://github.com/GregSutcliffe/smart-proxy

Cheers,
Greg

Curious, doesn't 1.8.7 also support RUBY_PLATFORM? My understanding is
that we were now 1.8.7+, so could safely just use that?

Thanks,
Brian

··· On Wed, Jun 13, 2012 at 7:40 AM, Greg Sutcliffe wrote: > Hi all, > > I've just created a pullreq for Ruby 1.9 support in the smart proxy, > while preserving 1.8 support. It seems to work for me on my 1.8 and > 1.9 proxies, but I'd love more testing. If anybody wants to have a > play, you can find it at https://github.com/GregSutcliffe/smart-proxy > > Cheers, > Greg

Good point! I'll update the pull req later today. Thanks!

··· On 13 June 2012 23:52, Brian Gupta wrote: > Curious, doesn't 1.8.7 also support RUBY_PLATFORM? My understanding is > that we were now 1.8.7+, so could safely just use that? > > Thanks, > Brian

Should we force that? Maybe the proxy can run on older distributions?

··· בתאריך 14 ביונ 2012 18:57, מאת "Greg Sutcliffe" : > > On 13 June 2012 23:52, Brian Gupta wrote: > > Curious, doesn't 1.8.7 also support RUBY_PLATFORM? My understanding is > > that we were now 1.8.7+, so could safely just use that? > > > > Thanks, > > Brian > > Good point! I'll update the pull req later today. Thanks!

I can leave it as is if you prefer.

Do you have anything else you'd like me to address on the pull
request? I don't think we settled the 'require ping' matter…

Greg

··· On 14 June 2012 17:13, Ohad Levy wrote: > Should we force that? Maybe the proxy can run on older distributions?

> > Should we force that? Maybe the proxy can run on older distributions?
>
> I can leave it as is if you prefer.
>
> Do you have anything else you'd like me to address on the pull
> request? I don't think we settled the 'require ping' matter…
>
I guess I need to figure out where it comes from, but i guess you can
require it only if its not ruby 1.9 etc…

Ohad

··· On Thu, Jun 14, 2012 at 7:27 PM, Greg Sutcliffe wrote: > On 14 June 2012 17:13, Ohad Levy wrote:

Greg