Searching for the foreman_default_hostgroup plugin maintainer

Marek_Hulan · May 26, 2021, 9:42am

Hello,

recently I saw a thread about foreman_default_hostgroup plugin, that reminded me it is broken since Foreman 2.2. Based on the community surverys, this was one of the most popular plugin. Given it wasn’t maintained since 2017 I today went through PRs there, closed those that were out of date, merged the PR with the fix for Foreman 2.2+ and released the new version 6.0.0.

However I don’t have time to actively maintain this plugin. If there’s ever a breaking change in future again, I may not notice for another year. I also can’t invest time into reviewing the PRs in there (though it’s 0 activity in the last year). Is there someone who’d be willing to take care of this plugin, monitor issues and new PRs and keep it up to date? I’d be happy to explain the release process and help initially if needed. Let me know if you’re interested.

lzap · May 26, 2021, 10:10am

Since we are moving fact parsers from plugins into core and this is nothing else than fact parser extension, maybe we could consider this feature when refactoring our fact parser plugins creating some way to hook into importing process and then merge this plugin into core. This plugin is so small and does some monkey patching that it is probably worth taking it into core now.

We do have something similar in discovery called import_hook it could be actually designed in a way that would be beneficial both to this plugin and discovery.

github.com

theforeman/foreman_discovery/blob/develop/app/services/foreman_discovery/import_hook_service.rb

module ForemanDiscovery
  class ImportHookService
    HOOKS = [
      ForemanDiscovery::ImportHooks::DiscoveryAttribute,
      ForemanDiscovery::ImportHooks::LldpNeighbor,
      ForemanDiscovery::ImportHooks::SubnetAndTaxonomy,
      ForemanDiscovery::ImportHooks::LockTemplates
    ]

    attr_reader :host, :facts

    def initialize(host:, facts:)
      @host = host
      @facts = facts
    end

    def after_populate
      HOOKS.each do |hook_class|
        hook = hook_class.new(host: host, facts: facts)
        hook.after_populate

This file has been truncated. show original

Long-term, I would love to see discovery being merged into core as it does a lot of fact importing hacks too. Since we are moving other fact parsers too, discovery should be not different as it is basically a puppet importer with few additional extensions (handling of special discovery_xyz facts).

@dmatoulek what you think?

dmatoulek · May 26, 2021, 10:35am

That’s a good idea!

I think it would be great addition for that. That’s reminds me that there is A LOT of things in my head for refactoring that It would worth for own thread

lzap · May 27, 2021, 7:49am

I volunteer to adopt the plugin.

Let me know how far did you get with the release and I am taking over. I see you updated the README.

I have the permissions on rubygems.org, @mcorr can you please give me permissions for the github page to be able to merge and push stuff?

mcorr · May 27, 2021, 7:58am

Done.
Let me know if you need anything else.