This topic needs a title

Partha_Aji · June 8, 2016, 7:04pm

While working on one of the org deletion bugs (
Bug #15336: Org/Location removal results in a ISE - Foreman) I hit upon this inconsistency
in Foreman code base and would like suggestions on the agreeable behavior.

So here is the user action

User creates an org
Assigns a host to that org
Deletes that org

There seem to be 2 different approaches taken in the foreman code
1)

github.com

theforeman/foreman/blob/develop/app/models/taxonomies/organization.rb#L8


class Organization < Taxonomy
extend FriendlyId
friendly_id :title
include Foreman::ThreadSession::OrganizationModel
include Parameterizable::ByIdName


has_and_belongs_to_many :locations, :join_table => 'locations_organizations', :validate => false
has_many_hosts :dependent => :nullify
before_destroy EnsureNotUsedBy.new(:hosts)


has_many :organization_parameters, :class_name => 'OrganizationParameter', :foreign_key => :reference_id,            :dependent => :destroy, :inverse_of => :organization
has_many :default_users,           :class_name => 'User',                  :foreign_key => :default_organization_id, :dependent => :nullify
accepts_nested_attributes_for :organization_parameters, :allow_destroy => true
include ParameterValidators


scope :completer_scope, ->(opts) { my_organizations }


scoped_search :on => :id, :validator => ScopedSearch::Validators::INTEGER, :rename => 'organization_id', :only_explicit => true

seems to indicate the intention to nullify the organization-host
association if organization gets deleted. This tells me that its ok to
delete the org with hosts associated to it.
"has_many_hosts :dependent => :nullify"

https://github.com/theforeman/foreman/blob/develop/test/functional/api/v2/locations_controller_test.rb#L74
seems to indicate we do Not want to delete orgs/locations if hosts are
attached to it. "should NOT destroy location if hosts use it" .

Looking at the commit dates for both, they were merged a mere month after
each other (jan - feb 2013). 2 came before 1 .

I prefer 1 over 2 … Unassociate the Org from the Host if the org gets
deleted instead of blocking the delete. Whats your preferred approach.
Kindly let me know.

Partha