Updating Foreman 2.2.1 to 2.3.1 and Katello 3.17.1 to 3.18 issue

ekohl · December 23, 2020, 3:40pm

I wrote about the installation layout in our Puppet module since upstream this was undocumented. Looking at it now, I also see I missed one thing (Correct directory tree in README by ekohl · Pull Request #159 · theforeman/puppet-pulpcore · GitHub).

Note that this layout was only applied since puppet-pulpcore 2.0.0. You can check this in /usr/share/foreman-installer/modules/pulpcore/metadata.json yourself. This is shipped since Foreman 2.3, which maps to 3.18. I also wrote a migration that’s supposed to migrate the directory layout:

github.com

theforeman/foreman-installer/blob/2.3-stable/hooks/pre/34-pulpcore_directory_layout.rb

require 'pathname'

PULP_ROOT = Pathname.new('/var/lib/pulp')
LEGACY_DIR = PULP_ROOT / 'docroot'
DESTINATION = PULP_ROOT / 'media'

if LEGACY_DIR.directory? && !LEGACY_DIR.symlink?
  logger.debug("Migrating #{LEGACY_DIR} to #{DESTINATION}")
  unless app_value(:noop)
    LEGACY_DIR.rename(DESTINATION)
    LEGACY_DIR.make_symlink(DESTINATION)
  end
end

github.com

theforeman/foreman-installer/blob/2.3-stable/hooks/post/34-pulpcore_directory_layout.rb

require 'pathname'

LEGACY_DIR = Pathname.new('/var/lib/pulp/docroot')

if LEGACY_DIR.symlink?
  logger.debug("Removing legacy symlink #{LEGACY_DIR}")
  LEGACY_DIR.unlink unless app_value(:noop)
end

It looks like I followed the upstream paths rather than our own paths. That is a major upgrade bug.

Some backstory: initially there was really no standard deployment layout and our layout was different than upstream. Obviously this is undesirable so over the past months I pushed for a standard that works well for our use case. https://github.com/pulp/pulpcore/pull/799 is not yet merged, but there is at least an approval that it’s the correct layout. This is also part of the SELinux policy.

I opened an untested PR but my working day is not that long so it’ll likely not see progress until the new year.
https://github.com/theforeman/foreman-installer/pull/634