avoid bikeshedding conversations about how $x should look like since there are always people who prefer $a and those who prefer $b
don’t reinvent the designs for things that fit Foreman project such as list views, cards etc
reuse components that were implemented in patternfly-react so we don’t have to build them from scratch
My hope is that people working on patternfly did the research and have good reasons for some decisions. When there’s something I disagree with, I open issue for patternfly like here or here. If they reject and I still disagree, I think it’s OK to start discussion in Foreman community and if it seems most would prefer the change, we can always adjust the pattern. Like we did with vertical nav, there’s now no delay for menu.
Regarding the login page specifically, I like the new layout. We just need to make it look like Foreman. For that I think we need to change the background (already in progress I think). I also don’t like the dynamic height of the form if there’s validation error or capslock warning, there may be good reasons for that but I’d start with opening issue against patternfly to see the reasoning behind it.
It’s really amazing to see how many from the community truly care about the product,
my thoughts are to keep the original background for this PR
because it isn’t really the issue here,
and later maybe with the help of designers replace it.
As for the margin in the form, for errors not to jump and push everything down,
I had a long discussion about it with Patternfly designers when I built this component for Patternfly,
but now, backed by you guys,
the design can change…
So I am going to open an issue soon to PF, attaching a link into this discussion and try to fix it there,
so the errors won’t be jumpy.
The designer who did the Foreman poster (and most likely has source files for the logo) is Jessica Cox. I’ve reached out to her to get said file. We can leverage this for the background.
I’d be inclined to stick with the patternfly recommendations and potentially ask them why they chose to do things this way. I do agree that it’s a little jarring but I also think that consistency with other projects that use patternfly is a good thing.
I agree with this sentiment. There were multiple reasons both for and against a static layout. The good part is that we can have discussions with PF about issues we’re seeing and try to influence the design. Overall I think PatternFly has had a positive influence on the product in terms of consistency.
Good news everyone !
Our designer @terezanovotna is starting to work on our background
and after we’ll have few examples to decide from, we’ll make a vote
Nice. I think you might get more feedback if you open a new thread. Also @Gwmngilfen or @tbrisker could create a poll in here, so we can have poll and discussion at one place.
I voted for Design 4 but I do miss the Foreman header (and helmet) above the login box. That’s why I was also thinking about Design 2. That is a bit too boring though. Design 3 does have all the elements I like, but I prefer the blue theme over de dark theme.
For those who’re working on designs, please also don’t forget there can be custom text specified in settings that should be displayed somewhere on the page E.g. below the login box.
Is that the welcome or version info? Or something I’m missing entirely. You know, the message can be pretty long, e.g. “This is a private system operated by XY, every user activity is logged and monitored. By logging in you agree with terms of use”. That’s why I thought it would be better below the form.
