What I would like to get out of using patternfly:
- avoid bikeshedding conversations about how $x should look like since there are always people who prefer $a and those who prefer $b
- don’t reinvent the designs for things that fit Foreman project such as list views, cards etc
- reuse components that were implemented in patternfly-react so we don’t have to build them from scratch
My hope is that people working on patternfly did the research and have good reasons for some decisions. When there’s something I disagree with, I open issue for patternfly like here or here. If they reject and I still disagree, I think it’s OK to start discussion in Foreman community and if it seems most would prefer the change, we can always adjust the pattern. Like we did with vertical nav, there’s now no delay for menu.
Regarding the login page specifically, I like the new layout. We just need to make it look like Foreman. For that I think we need to change the background (already in progress I think). I also don’t like the dynamic height of the form if there’s validation error or capslock warning, there may be good reasons for that but I’d start with opening issue against patternfly to see the reasoning behind it.